All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration
@ 2025-10-25 14:35 Thomas Devoogdt
  2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Thomas Devoogdt @ 2025-10-25 14:35 UTC (permalink / raw)
  To: buildroot; +Cc: Adrian Perez de Castro, Thomas Devoogdt

WebKit's auto-configured ccache results in 100% cache misses.
Disable WebKit's internal ccache setup [1] since Buildroot
already manages the ccache in toolchain/toolchain-wrapper.c.

[1] https://github.com/WebKit/WebKit/blob/wpewebkit-2.48.3/Source/cmake/WebKitCCache.cmake

Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>
---
 package/wpewebkit/wpewebkit.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index 796e271ecb..15a2ea93e8 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -21,6 +21,10 @@ WPEWEBKIT_DEPENDENCIES = host-gperf host-python3 host-ruby host-unifdef \
 
 WPEWEBKIT_CMAKE_BACKEND = ninja
 
+# Buildroot adds support for ccache through its
+# toolchain-wrapper, so tell wpewebkit not to mess with it.
+WPEWEBKIT_CONF_ENV = WK_USE_CCACHE=NO
+
 WPEWEBKIT_CONF_OPTS = \
 	-DPORT=WPE \
 	-DENABLE_API_TESTS=OFF \
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH v1] package/webkitgtk: disable internal ccache configuration
  2025-10-25 14:35 [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration Thomas Devoogdt
@ 2025-10-25 14:35 ` Thomas Devoogdt
  2025-10-27 13:31   ` Adrian Perez de Castro
  2025-11-02 19:45   ` Peter Korsgaard
  2025-10-27 13:30 ` [Buildroot] [PATCH v1] package/wpewebkit: " Adrian Perez de Castro
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 7+ messages in thread
From: Thomas Devoogdt @ 2025-10-25 14:35 UTC (permalink / raw)
  To: buildroot; +Cc: Adrian Perez de Castro, Thomas Devoogdt

From: Thomas Devoogdt <thomas.devoogdt@barco.com>

WebKit's auto-configured ccache results in 100% cache misses.
Disable WebKit's internal ccache setup [1] since Buildroot
already manages the ccache in toolchain/toolchain-wrapper.c.

[1] https://github.com/WebKit/WebKit/blob/webkitgtk-2.50.1/Source/cmake/WebKitCCache.cmake

Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
---
 package/webkitgtk/webkitgtk.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 0b6a1383ca..fecca3529d 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -19,6 +19,10 @@ WEBKITGTK_DEPENDENCIES = host-ruby host-python3 host-gperf host-unifdef \
 
 WEBKITGTK_CMAKE_BACKEND = ninja
 
+# Buildroot adds support for ccache through its
+# toolchain-wrapper, so tell webkitgtk not to mess with it.
+WEBKITGTK_CONF_ENV = WK_USE_CCACHE=NO
+
 WEBKITGTK_CONF_OPTS = \
 	-DENABLE_API_TESTS=OFF \
 	-DENABLE_DOCUMENTATION=OFF \
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration
  2025-10-25 14:35 [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration Thomas Devoogdt
  2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
@ 2025-10-27 13:30 ` Adrian Perez de Castro
  2025-11-02 19:45 ` Peter Korsgaard
  2025-11-17 20:02 ` Arnout Vandecappelle via buildroot
  3 siblings, 0 replies; 7+ messages in thread
From: Adrian Perez de Castro @ 2025-10-27 13:30 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Thomas Devoogdt


[-- Attachment #1.1: Type: text/plain, Size: 1328 bytes --]

On Sat, 25 Oct 2025 16:35:11 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> WebKit's auto-configured ccache results in 100% cache misses.
> Disable WebKit's internal ccache setup [1] since Buildroot
> already manages the ccache in toolchain/toolchain-wrapper.c.
> 
> [1] https://github.com/WebKit/WebKit/blob/wpewebkit-2.48.3/Source/cmake/WebKitCCache.cmake
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/wpewebkit/wpewebkit.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 796e271ecb..15a2ea93e8 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -21,6 +21,10 @@ WPEWEBKIT_DEPENDENCIES = host-gperf host-python3 host-ruby host-unifdef \
>  
>  WPEWEBKIT_CMAKE_BACKEND = ninja
>  
> +# Buildroot adds support for ccache through its
> +# toolchain-wrapper, so tell wpewebkit not to mess with it.
> +WPEWEBKIT_CONF_ENV = WK_USE_CCACHE=NO
> +
>  WPEWEBKIT_CONF_OPTS = \
>  	-DPORT=WPE \
>  	-DENABLE_API_TESTS=OFF \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1] package/webkitgtk: disable internal ccache configuration
  2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
@ 2025-10-27 13:31   ` Adrian Perez de Castro
  2025-11-02 19:45   ` Peter Korsgaard
  1 sibling, 0 replies; 7+ messages in thread
From: Adrian Perez de Castro @ 2025-10-27 13:31 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Thomas Devoogdt


[-- Attachment #1.1: Type: text/plain, Size: 1405 bytes --]

On Sat, 25 Oct 2025 16:35:12 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 
> WebKit's auto-configured ccache results in 100% cache misses.
> Disable WebKit's internal ccache setup [1] since Buildroot
> already manages the ccache in toolchain/toolchain-wrapper.c.
> 
> [1] https://github.com/WebKit/WebKit/blob/webkitgtk-2.50.1/Source/cmake/WebKitCCache.cmake
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Acked-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
>  package/webkitgtk/webkitgtk.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 0b6a1383ca..fecca3529d 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -19,6 +19,10 @@ WEBKITGTK_DEPENDENCIES = host-ruby host-python3 host-gperf host-unifdef \
>  
>  WEBKITGTK_CMAKE_BACKEND = ninja
>  
> +# Buildroot adds support for ccache through its
> +# toolchain-wrapper, so tell webkitgtk not to mess with it.
> +WEBKITGTK_CONF_ENV = WK_USE_CCACHE=NO
> +
>  WEBKITGTK_CONF_OPTS = \
>  	-DENABLE_API_TESTS=OFF \
>  	-DENABLE_DOCUMENTATION=OFF \
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration
  2025-10-25 14:35 [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration Thomas Devoogdt
  2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
  2025-10-27 13:30 ` [Buildroot] [PATCH v1] package/wpewebkit: " Adrian Perez de Castro
@ 2025-11-02 19:45 ` Peter Korsgaard
  2025-11-17 20:02 ` Arnout Vandecappelle via buildroot
  3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2025-11-02 19:45 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Adrian Perez de Castro

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:

 > WebKit's auto-configured ccache results in 100% cache misses.
 > Disable WebKit's internal ccache setup [1] since Buildroot
 > already manages the ccache in toolchain/toolchain-wrapper.c.

 > [1] https://github.com/WebKit/WebKit/blob/wpewebkit-2.48.3/Source/cmake/WebKitCCache.cmake

 > Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1] package/webkitgtk: disable internal ccache configuration
  2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
  2025-10-27 13:31   ` Adrian Perez de Castro
@ 2025-11-02 19:45   ` Peter Korsgaard
  1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2025-11-02 19:45 UTC (permalink / raw)
  To: Thomas Devoogdt; +Cc: buildroot, Adrian Perez de Castro, Thomas Devoogdt

>>>>> "Thomas" == Thomas Devoogdt <thomas@devoogdt.com> writes:

 > From: Thomas Devoogdt <thomas.devoogdt@barco.com>
 > WebKit's auto-configured ccache results in 100% cache misses.
 > Disable WebKit's internal ccache setup [1] since Buildroot
 > already manages the ccache in toolchain/toolchain-wrapper.c.

 > [1] https://github.com/WebKit/WebKit/blob/webkitgtk-2.50.1/Source/cmake/WebKitCCache.cmake

 > Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration
  2025-10-25 14:35 [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration Thomas Devoogdt
                   ` (2 preceding siblings ...)
  2025-11-02 19:45 ` Peter Korsgaard
@ 2025-11-17 20:02 ` Arnout Vandecappelle via buildroot
  3 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2025-11-17 20:02 UTC (permalink / raw)
  To: Thomas Devoogdt, buildroot; +Cc: Adrian Perez de Castro



On 25/10/2025 16:35, Thomas Devoogdt wrote:
> WebKit's auto-configured ccache results in 100% cache misses.
> Disable WebKit's internal ccache setup [1] since Buildroot
> already manages the ccache in toolchain/toolchain-wrapper.c.
> 
> [1] https://github.com/WebKit/WebKit/blob/wpewebkit-2.48.3/Source/cmake/WebKitCCache.cmake
> 
> Signed-off-by: Thomas Devoogdt <thomas@devoogdt.com>

  Applied both to 2025.02.x and 2025.08.x, thanks.

  Regards,
  Arnout

> ---
>   package/wpewebkit/wpewebkit.mk | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> index 796e271ecb..15a2ea93e8 100644
> --- a/package/wpewebkit/wpewebkit.mk
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -21,6 +21,10 @@ WPEWEBKIT_DEPENDENCIES = host-gperf host-python3 host-ruby host-unifdef \
>   
>   WPEWEBKIT_CMAKE_BACKEND = ninja
>   
> +# Buildroot adds support for ccache through its
> +# toolchain-wrapper, so tell wpewebkit not to mess with it.
> +WPEWEBKIT_CONF_ENV = WK_USE_CCACHE=NO
> +
>   WPEWEBKIT_CONF_OPTS = \
>   	-DPORT=WPE \
>   	-DENABLE_API_TESTS=OFF \

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-11-17 20:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-25 14:35 [Buildroot] [PATCH v1] package/wpewebkit: disable internal ccache configuration Thomas Devoogdt
2025-10-25 14:35 ` [Buildroot] [PATCH v1] package/webkitgtk: " Thomas Devoogdt
2025-10-27 13:31   ` Adrian Perez de Castro
2025-11-02 19:45   ` Peter Korsgaard
2025-10-27 13:30 ` [Buildroot] [PATCH v1] package/wpewebkit: " Adrian Perez de Castro
2025-11-02 19:45 ` Peter Korsgaard
2025-11-17 20:02 ` Arnout Vandecappelle via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.