From: Jakub Kicinski <kuba@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Gal Pressman <gal@nvidia.com>, Johan Hovold <johan@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
Alexei Lazar <alazar@nvidia.com>, Simon Horman <horms@kernel.org>,
cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates"
Date: Wed, 29 Oct 2025 10:26:30 -0700 [thread overview]
Message-ID: <20251029102630.2a9bd6e7@kernel.org> (raw)
In-Reply-To: <47ef2f61-85c1-92fa-12dc-e5918d90488@inria.fr>
On Wed, 29 Oct 2025 15:04:36 +0100 (CET) Julia Lawall wrote:
> > The test by no means mandates authors to use %pe, as the output says:
> > WARNING: Consider using %pe to print PTR_ERR()
> >
> > "Consider" :).
> >
> > I would consider it best practice to use it, and a few drivers were
> > converted thanks to this test.
> >
> > If the issue is with automatic build bots, then maybe this test should
> > be excluded from them, rather than deleted?
>
> This is easy to do. Or I can discard them when they come to me for
> approval.
FWIW I'd also prefer for the script to say in the tree.
Some kind of opt-out mechanism per subsystem would be ideal,
and presumably belongs in the bots themselves. We maintain
a list of regexp's in netdev CI to silence cocci checks we
don't find worth complaining about. But the %pe check so far
have not been too bad.
And we have a policy against semi-automated patches which "clean up"
cocci or checkpatch warnings. Something we may want to adopt more
widely.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Gal Pressman <gal@nvidia.com>, Johan Hovold <johan@kernel.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
Alexei Lazar <alazar@nvidia.com>, Simon Horman <horms@kernel.org>,
cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates"
Date: Wed, 29 Oct 2025 10:26:30 -0700 [thread overview]
Message-ID: <20251029102630.2a9bd6e7@kernel.org> (raw)
In-Reply-To: <47ef2f61-85c1-92fa-12dc-e5918d90488@inria.fr>
On Wed, 29 Oct 2025 15:04:36 +0100 (CET) Julia Lawall wrote:
> > The test by no means mandates authors to use %pe, as the output says:
> > WARNING: Consider using %pe to print PTR_ERR()
> >
> > "Consider" :).
> >
> > I would consider it best practice to use it, and a few drivers were
> > converted thanks to this test.
> >
> > If the issue is with automatic build bots, then maybe this test should
> > be excluded from them, rather than deleted?
>
> This is easy to do. Or I can discard them when they come to me for
> approval.
FWIW I'd also prefer for the script to say in the tree.
Some kind of opt-out mechanism per subsystem would be ideal,
and presumably belongs in the bots themselves. We maintain
a list of regexp's in netdev CI to silence cocci checks we
don't find worth complaining about. But the %pe check so far
have not been too bad.
And we have a policy against semi-automated patches which "clean up"
cocci or checkpatch warnings. Something we may want to adopt more
widely.
next prev parent reply other threads:[~2025-10-29 17:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 13:29 [cocci] [PATCH] Revert "scripts/coccinelle: Find PTR_ERR() to %pe candidates" Johan Hovold
2025-10-29 13:29 ` Johan Hovold
2025-10-29 13:59 ` [cocci] " Gal Pressman
2025-10-29 13:59 ` Gal Pressman
2025-10-29 14:04 ` [cocci] " Julia Lawall
2025-10-29 14:04 ` Julia Lawall
2025-10-29 17:26 ` Jakub Kicinski [this message]
2025-10-29 17:26 ` Jakub Kicinski
2025-10-29 16:38 ` [cocci] " Johan Hovold
2025-10-29 16:38 ` Johan Hovold
2025-10-29 17:00 ` [cocci] " Markus Elfring
2025-10-29 17:35 ` [cocci] [PATCH] " Gal Pressman
2025-10-29 17:35 ` Gal Pressman
2025-10-30 14:06 ` [cocci] " Johan Hovold
2025-10-30 14:06 ` Johan Hovold
2025-10-30 14:36 ` [cocci] " Gal Pressman
2025-10-30 14:36 ` Gal Pressman
2025-10-31 14:10 ` [cocci] " Johan Hovold
2025-10-31 14:10 ` Johan Hovold
2025-10-30 7:36 ` [cocci] " Julia Lawall
2025-10-30 7:36 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029102630.2a9bd6e7@kernel.org \
--to=kuba@kernel.org \
--cc=alazar@nvidia.com \
--cc=cocci@inria.fr \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=johan@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.