drivers/staging/gpib/gpio/gpib_bitbang.c:1204:24-31: WARNING: Consider using %pe to print PTR_ERR()

drivers/staging/gpib/gpio/gpib_bitbang.c:1204:24-31: WARNING: Consider using %pe to print PTR_ERR()

[kernel test robot]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Dave Penkler <dpenkler@gmail.com>

Hi Dave,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e53642b87a4f4b03a8d7e5f8507fc3cd0c595ea6
commit: 165e8cc3cfec9ef51f3376b0d49b115294f34f3b staging: gpib: Add KBUILD files for GPIB drivers
date:   1 year, 1 month ago
:::::: branch date: 29 hours ago
:::::: commit date: 1 year, 1 month ago
config: loongarch-randconfig-r062-20251030 (https://download.01.org/0day-ci/archive/20251030/202510301308.JLr3AzNZ-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202510301308.JLr3AzNZ-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/staging/gpib/gpio/gpib_bitbang.c:1204:24-31: WARNING: Consider using %pe to print PTR_ERR()

vim +1204 drivers/staging/gpib/gpio/gpib_bitbang.c

4cd654f847693c2 Dave Penkler 2024-09-18  1163  
4cd654f847693c2 Dave Penkler 2024-09-18  1164  static int allocate_gpios(gpib_board_t *board)
4cd654f847693c2 Dave Penkler 2024-09-18  1165  {
4cd654f847693c2 Dave Penkler 2024-09-18  1166  	int j, retval = 0;
4cd654f847693c2 Dave Penkler 2024-09-18  1167  	bool error = false;
4cd654f847693c2 Dave Penkler 2024-09-18  1168  	int table_index = 0;
4cd654f847693c2 Dave Penkler 2024-09-18  1169  	char name[256];
4cd654f847693c2 Dave Penkler 2024-09-18  1170  	struct gpio_desc *desc;
4cd654f847693c2 Dave Penkler 2024-09-18  1171  	struct gpiod_lookup_table *lookup_table;
4cd654f847693c2 Dave Penkler 2024-09-18  1172  
4cd654f847693c2 Dave Penkler 2024-09-18  1173  	if (!board->gpib_dev) {
4cd654f847693c2 Dave Penkler 2024-09-18  1174  		pr_err("NULL gpib dev for board\n");
4cd654f847693c2 Dave Penkler 2024-09-18  1175  		return -ENOENT;
4cd654f847693c2 Dave Penkler 2024-09-18  1176  	}
4cd654f847693c2 Dave Penkler 2024-09-18  1177  
4cd654f847693c2 Dave Penkler 2024-09-18  1178  	lookup_table = lookup_tables[0];
4cd654f847693c2 Dave Penkler 2024-09-18  1179  	lookup_table->dev_id   = dev_name(board->gpib_dev);
4cd654f847693c2 Dave Penkler 2024-09-18  1180  	gpiod_add_lookup_table(lookup_table);
4cd654f847693c2 Dave Penkler 2024-09-18  1181  	dbg_printk(1, "Allocating gpios using table index %d\n", table_index);
4cd654f847693c2 Dave Penkler 2024-09-18  1182  
4cd654f847693c2 Dave Penkler 2024-09-18  1183  	for (j = 0 ; j < NUM_PINS ; j++) {
4cd654f847693c2 Dave Penkler 2024-09-18  1184  		if (gpios_vector[j] < 0)
4cd654f847693c2 Dave Penkler 2024-09-18  1185  			continue;
4cd654f847693c2 Dave Penkler 2024-09-18  1186  		/* name not really used in gpiod_get_index() */
4cd654f847693c2 Dave Penkler 2024-09-18  1187  		sprintf(name, "GPIO%d", gpios_vector[j]);
4cd654f847693c2 Dave Penkler 2024-09-18  1188  try_again:
4cd654f847693c2 Dave Penkler 2024-09-18  1189  		dbg_printk(1, "Allocating gpio %s pin no %d\n", name, gpios_vector[j]);
4cd654f847693c2 Dave Penkler 2024-09-18  1190  		desc = gpiod_get_index(board->gpib_dev, name, gpios_vector[j], GPIOD_IN);
4cd654f847693c2 Dave Penkler 2024-09-18  1191  
4cd654f847693c2 Dave Penkler 2024-09-18  1192  		if (IS_ERR(desc)) {
4cd654f847693c2 Dave Penkler 2024-09-18  1193  			gpiod_remove_lookup_table(lookup_table);
4cd654f847693c2 Dave Penkler 2024-09-18  1194  			table_index++;
4cd654f847693c2 Dave Penkler 2024-09-18  1195  			lookup_table = lookup_tables[table_index];
4cd654f847693c2 Dave Penkler 2024-09-18  1196  			if (lookup_table) {
4cd654f847693c2 Dave Penkler 2024-09-18  1197  				dbg_printk(1, "Allocation failed,  now  using table_index %d\n",
4cd654f847693c2 Dave Penkler 2024-09-18  1198  					   table_index);
4cd654f847693c2 Dave Penkler 2024-09-18  1199  				lookup_table->dev_id = dev_name(board->gpib_dev);
4cd654f847693c2 Dave Penkler 2024-09-18  1200  				gpiod_add_lookup_table(lookup_table);
4cd654f847693c2 Dave Penkler 2024-09-18  1201  				goto try_again;
4cd654f847693c2 Dave Penkler 2024-09-18  1202  			}
4cd654f847693c2 Dave Penkler 2024-09-18  1203  			dbg_printk(0, "Unable to obtain gpio descriptor for pin %d error %ld\n",
4cd654f847693c2 Dave Penkler 2024-09-18 @1204  				   gpios_vector[j], PTR_ERR(desc));
4cd654f847693c2 Dave Penkler 2024-09-18  1205  			error = true;
4cd654f847693c2 Dave Penkler 2024-09-18  1206  			break;
4cd654f847693c2 Dave Penkler 2024-09-18  1207  		}
4cd654f847693c2 Dave Penkler 2024-09-18  1208  		all_descriptors[j] = desc;
4cd654f847693c2 Dave Penkler 2024-09-18  1209  	}
4cd654f847693c2 Dave Penkler 2024-09-18  1210  
4cd654f847693c2 Dave Penkler 2024-09-18  1211  	if (error) { /* undo what already done */
4cd654f847693c2 Dave Penkler 2024-09-18  1212  		release_gpios();
4cd654f847693c2 Dave Penkler 2024-09-18  1213  		retval = -1;
4cd654f847693c2 Dave Penkler 2024-09-18  1214  	}
4cd654f847693c2 Dave Penkler 2024-09-18  1215  	if (lookup_table)
4cd654f847693c2 Dave Penkler 2024-09-18  1216  		gpiod_remove_lookup_table(lookup_table);
4cd654f847693c2 Dave Penkler 2024-09-18  1217  	// Initialize LED trigger
4cd654f847693c2 Dave Penkler 2024-09-18  1218  	led_trigger_register_simple("gpib", &ledtrig_gpib);
4cd654f847693c2 Dave Penkler 2024-09-18  1219  	return retval;
4cd654f847693c2 Dave Penkler 2024-09-18  1220  }
4cd654f847693c2 Dave Penkler 2024-09-18  1221  

:::::: The code at line 1204 was first introduced by commit
:::::: 4cd654f847693c2c60312acfcab25936bb31aa1c staging: gpib: Add gpio bitbang GPIB driver

:::::: TO: Dave Penkler <dpenkler@gmail.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki