All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-rockchip][PATCH] fix sed invocation
@ 2025-11-04 17:45 Trevor Woerner
  2025-11-04 17:56 ` [yocto-patches] " Quentin Schulz
  2025-11-05 13:53 ` Trevor Woerner
  0 siblings, 2 replies; 3+ messages in thread
From: Trevor Woerner @ 2025-11-04 17:45 UTC (permalink / raw)
  To: yocto-patches

"sed -ie" is different than "sed -i -e". Although both run the script on
the intended file in-place, the first one creates a backup. These two
were accidentally merged into one option which can sometimes work, but
not in this case.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 .../rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dynamic-layers/rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend b/dynamic-layers/rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend
index 323b63b01f40..82dec84a8d5c 100644
--- a/dynamic-layers/rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend
+++ b/dynamic-layers/rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend
@@ -5,5 +5,5 @@ PACKAGE_ARCH:rk-rauc-demo = "${MACHINE_ARCH}"
 FILESEXTRAPATHS:prepend:rk-rauc-demo := "${THISDIR}/files:"
 
 do_install:prepend:rk-rauc-demo() {
-	sed -ie 's!@MACHINE@!${MACHINE}!g' ${UNPACKDIR}/system.conf
+	sed -i -e 's!@MACHINE@!${MACHINE}!g' ${UNPACKDIR}/system.conf
 }
-- 
2.51.0.193.g4975ec3473b4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [yocto-patches] [meta-rockchip][PATCH] fix sed invocation
  2025-11-04 17:45 [meta-rockchip][PATCH] fix sed invocation Trevor Woerner
@ 2025-11-04 17:56 ` Quentin Schulz
  2025-11-05 13:53 ` Trevor Woerner
  1 sibling, 0 replies; 3+ messages in thread
From: Quentin Schulz @ 2025-11-04 17:56 UTC (permalink / raw)
  To: yocto-patches

Hi Trevor,

On 11/4/25 6:45 PM, Trevor Woerner via lists.yoctoproject.org wrote:
> "sed -ie" is different than "sed -i -e". Although both run the script on

Nice catch!

> the intended file in-place, the first one creates a backup. These two
> were accidentally merged into one option which can sometimes work, but
> not in this case.
> 

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-rockchip][PATCH] fix sed invocation
  2025-11-04 17:45 [meta-rockchip][PATCH] fix sed invocation Trevor Woerner
  2025-11-04 17:56 ` [yocto-patches] " Quentin Schulz
@ 2025-11-05 13:53 ` Trevor Woerner
  1 sibling, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2025-11-05 13:53 UTC (permalink / raw)
  To: yocto-patches

On Tue 2025-11-04 @ 12:45:16 PM, Trevor Woerner wrote:
> "sed -ie" is different than "sed -i -e". Although both run the script on
> the intended file in-place, the first one creates a backup. These two
> were accidentally merged into one option which can sometimes work, but
> not in this case.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  .../rk-rauc-demo/recipes-core/rauc/rauc-conf.bbappend           | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to meta-rockchip, master branch.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-05 14:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 17:45 [meta-rockchip][PATCH] fix sed invocation Trevor Woerner
2025-11-04 17:56 ` [yocto-patches] " Quentin Schulz
2025-11-05 13:53 ` Trevor Woerner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.