All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
	damon.ding@rock-chips.com, jbx6244@gmail.com, heiko@sntech.de,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 4/5] arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
Date: Wed,  5 Nov 2025 14:57:07 -0600	[thread overview]
Message-ID: <20251105205708.732125-5-macroalpha82@gmail.com> (raw)
In-Reply-To: <20251105205708.732125-1-macroalpha82@gmail.com>

From: Chris Morgan <macromorgan@hotmail.com>

Once the DLL_STRBIN_TAPNUM_DEFAULT is set to the correct value [1], the
workaround to ensure stable eMMC operation is no longer needed. I
have observed testing this that hdparm went from:
"Timing buffered disk reads: 502 MB in  3.00 seconds = 167.14 MB/sec"
to the following:
"Timing buffered disk reads: 832 MB in  3.00 seconds = 277.32 MB/sec"

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/mmc/host/sdhci-of-dwcmshc.c?id=a28352cf2d2f8380e7aca8cb61682396dca7a991

Fixes: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index 62c8c8f68713..0796ba6d2504 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -561,10 +561,10 @@ &saradc {
 	status = "okay";
 };
 
-/* HS400 modes seemed to cause io errors. */
 &sdhci {
 	bus-width = <8>;
-	no-mmc-hs400;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
 	no-sd;
 	no-sdio;
 	non-removable;
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, sebastian.reichel@collabora.com,
	damon.ding@rock-chips.com, jbx6244@gmail.com, heiko@sntech.de,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	Chris Morgan <macromorgan@hotmail.com>
Subject: [PATCH 4/5] arm64: dts: rockchip: Enable HS400 for Indiedroid Nova
Date: Wed,  5 Nov 2025 14:57:07 -0600	[thread overview]
Message-ID: <20251105205708.732125-5-macroalpha82@gmail.com> (raw)
In-Reply-To: <20251105205708.732125-1-macroalpha82@gmail.com>

From: Chris Morgan <macromorgan@hotmail.com>

Once the DLL_STRBIN_TAPNUM_DEFAULT is set to the correct value [1], the
workaround to ensure stable eMMC operation is no longer needed. I
have observed testing this that hdparm went from:
"Timing buffered disk reads: 502 MB in  3.00 seconds = 167.14 MB/sec"
to the following:
"Timing buffered disk reads: 832 MB in  3.00 seconds = 277.32 MB/sec"

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/mmc/host/sdhci-of-dwcmshc.c?id=a28352cf2d2f8380e7aca8cb61682396dca7a991

Fixes: 3900160e164b ("arm64: dts: rockchip: Add Indiedroid Nova board")
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
index 62c8c8f68713..0796ba6d2504 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts
@@ -561,10 +561,10 @@ &saradc {
 	status = "okay";
 };
 
-/* HS400 modes seemed to cause io errors. */
 &sdhci {
 	bus-width = <8>;
-	no-mmc-hs400;
+	mmc-hs400-1_8v;
+	mmc-hs400-enhanced-strobe;
 	no-sd;
 	no-sdio;
 	non-removable;
-- 
2.43.0


  parent reply	other threads:[~2025-11-05 20:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 20:57 [PATCH 0/5] Indiedroid Nova Devicetree Updates Chris Morgan
2025-11-05 20:57 ` Chris Morgan
2025-11-05 20:57 ` [PATCH 1/5] arm64: dts: rockchip: Add device type for Indiedroid Nova Chris Morgan
2025-11-05 20:57   ` Chris Morgan
2025-11-05 20:57 ` [PATCH 2/5] arm64: dts: rockchip: Add Additional pinctrl defs " Chris Morgan
2025-11-05 20:57   ` Chris Morgan
2025-11-06 19:45   ` Heiko Stuebner
2025-11-06 19:45     ` Heiko Stuebner
2025-11-06 23:45     ` Chris Morgan
2025-11-06 23:45       ` Chris Morgan
2025-11-05 20:57 ` [PATCH 3/5] arm64: dts: rockchip: enable NPU on " Chris Morgan
2025-11-05 20:57   ` Chris Morgan
2025-11-05 20:57 ` Chris Morgan [this message]
2025-11-05 20:57   ` [PATCH 4/5] arm64: dts: rockchip: Enable HS400 for " Chris Morgan
2025-11-05 23:18   ` Heiko Stuebner
2025-11-05 23:18     ` Heiko Stuebner
2025-11-06  1:06     ` Chris Morgan
2025-11-06  1:06       ` Chris Morgan
2025-11-05 20:57 ` [PATCH 5/5] arm64: dts: rockchip: Fix DMA for Indiedroid Nova Bluetooth Chris Morgan
2025-11-05 20:57   ` Chris Morgan
2025-11-06 22:58 ` (subset) [PATCH 0/5] Indiedroid Nova Devicetree Updates Heiko Stuebner
2025-11-06 22:58   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251105205708.732125-5-macroalpha82@gmail.com \
    --to=macroalpha82@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=damon.ding@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macromorgan@hotmail.com \
    --cc=robh@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.