From: Greg KH <gregkh@linuxfoundation.org>
To: Dharanitharan R <dharanitharan725@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com,
syzbot+b4d5d8faea6996fd55e3@syzkaller.appspotmail.com,
syzbot+b4d5d8faea6996fd@syzkaller.appspotmail.com
Subject: Re: [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150_open
Date: Wed, 5 Nov 2025 07:19:02 +0900 [thread overview]
Message-ID: <2025110531-replace-grass-3c41@gregkh> (raw)
In-Reply-To: <20251104164838.17846-1-dharanitharan725@gmail.com>
On Tue, Nov 04, 2025 at 04:48:37PM +0000, Dharanitharan R wrote:
> KMSAN reported an uninitialized value use in rtl8150_open().
> Initialize rx_skb->data and intr_buff before submitting URBs to
> ensure memory is in a defined state.
>
> Reported-by: syzbot+b4d5d8faea6996fd@syzkaller.appspotmail.com
> Signed-off-by: Dharanitharan R <dharanitharan725@gmail.com>
> ---
> drivers/net/usb/rtl8150.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
> index 278e6cb6f4d9..f1a868f0032e 100644
> --- a/drivers/net/usb/rtl8150.c
> +++ b/drivers/net/usb/rtl8150.c
> @@ -719,14 +719,15 @@ static netdev_tx_t rtl8150_start_xmit(struct sk_buff *skb,
>
> static void set_carrier(struct net_device *netdev)
> {
> - rtl8150_t *dev = netdev_priv(netdev);
> - short tmp;
> + rtl8150_t *dev = netdev_priv(netdev);
> + short tmp;
Always run checkpatch on your changes so you don't get grumpy
maintainers asking why you didn't run checkpatch on your change :)
Please fix and send a v2.
thanks,
greg k-h
next prev parent reply other threads:[~2025-11-04 22:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202508272322.b4d5d8faea6996fd@syzkaller.appspotmail.com>
2025-11-04 16:48 ` [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150_open Dharanitharan R
2025-11-04 22:19 ` Greg KH [this message]
2025-11-04 16:27 Dharanitharan R
2025-11-04 16:27 ` syzbot
2025-11-04 17:52 ` Andrew Lunn
2025-11-04 17:52 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025110531-replace-grass-3c41@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=dharanitharan725@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+b4d5d8faea6996fd55e3@syzkaller.appspotmail.com \
--cc=syzbot+b4d5d8faea6996fd@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.