All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot@syzkaller.appspotmail.com>
To: andrew@lunn.ch
Cc: andrew@lunn.ch, davem@davemloft.net, dharanitharan725@gmail.com,
	 edumazet@google.com, gregkh@linuxfoundation.org,
	kuba@kernel.org,  linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150_open
Date: Tue, 04 Nov 2025 09:52:45 -0800	[thread overview]
Message-ID: <690a3d6d.050a0220.98a6.00b6.GAE@google.com> (raw)
In-Reply-To: <ea06bbfb-d14b-4c61-8394-c536ca2a67ce@lunn.ch>

> On Tue, Nov 04, 2025 at 04:27:16PM +0000, Dharanitharan R wrote:
>> KMSAN reported an uninitialized value use in rtl8150_open().
>> Initialize rx_skb->data and intr_buff before submitting URBs to
>> ensure memory is in a defined state.
>> 
>> Reported-by: syzbot+b4d5d8faea6996fd@syzkaller.appspotmail.com
>> Signed-off-by: Dharanitharan R <dharanitharan725@gmail.com>
>> ---
>>  drivers/net/usb/rtl8150.c | 21 ++++++++++++++-------
>>  1 file changed, 14 insertions(+), 7 deletions(-)
>> 
>> diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
>> index 278e6cb6f4d9..f1a868f0032e 100644
>> --- a/drivers/net/usb/rtl8150.c
>> +++ b/drivers/net/usb/rtl8150.c
>> @@ -719,14 +719,15 @@ static netdev_tx_t rtl8150_start_xmit(struct sk_buff *skb,
>>  
>>  static void set_carrier(struct net_device *netdev)
>>  {
>> -	rtl8150_t *dev = netdev_priv(netdev);
>> -	short tmp;
>> +    rtl8150_t *dev = netdev_priv(netdev);
>> +    short tmp;
>
> You are messing up the whitespace here.
>
> Did you not read your own patch and notice this problem? checkpatch
> probably also complained.
>
>     Andrew
>
> ---
> pw-bot: cr

I see the command but can't find the corresponding bug.
The email is sent to  syzbot+HASH@syzkaller.appspotmail.com address
but the HASH does not correspond to any known bug.
Please double check the address.


  reply	other threads:[~2025-11-04 17:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 16:27 [PATCH] [PATCH] usb: rtl8150: Initialize buffers to fix KMSAN uninit-value in rtl8150_open Dharanitharan R
2025-11-04 16:27 ` syzbot
2025-11-04 17:52 ` Andrew Lunn
2025-11-04 17:52   ` syzbot [this message]
     [not found] <202508272322.b4d5d8faea6996fd@syzkaller.appspotmail.com>
2025-11-04 16:48 ` Dharanitharan R
2025-11-04 22:19   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=690a3d6d.050a0220.98a6.00b6.GAE@google.com \
    --to=syzbot@syzkaller.appspotmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dharanitharan725@gmail.com \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.