From: "Theodore Ts'o" <tytso@mit.edu>
To: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"wqu@suse.com" <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"glaubitz@physik.fu-berlin.de" <glaubitz@physik.fu-berlin.de>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC] Why generic/073 is generic but not btrfs specific?
Date: Sat, 8 Nov 2025 09:01:16 -0500 [thread overview]
Message-ID: <20251108140116.GB2988753@mit.edu> (raw)
In-Reply-To: <ee43d81115d91ceb359f697162f21ce50cee29ff.camel@ibm.com>
On Thu, Nov 06, 2025 at 10:29:46PM +0000, Viacheslav Dubeyko wrote:
> > > Technically speaking, HFS+ is journaling file system in Apple implementation.
> > > But we don't have this functionality implemented and fully supported on Linux
> > > kernel side. Potentially, it can be done but currently we haven't such
> > > functionality yet. So, HFS/HFS+ doesn't use journaling on Linux kernel side and
> > > no journal replay could happen. :)
If the implementation of HJFJS+ in Linux doesn't support metadata
consistency after a crash, I'd suggest adding HFS+ to
_has_metadat_journalling(). This will suppress a number of test
failures so you can focus on other issues which arguably is probably
higher priority for you to fix.
After you get HFS+ to run clean with the journalling tesets skipped,
then you can focus on adding that guarantee at that point, perhaps?
- Ted
next prev parent reply other threads:[~2025-11-08 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:40 [RFC] Why generic/073 is generic but not btrfs specific? Viacheslav Dubeyko
2025-11-06 20:58 ` Qu Wenruo
2025-11-06 21:11 ` Viacheslav Dubeyko
2025-11-06 21:32 ` Qu Wenruo
2025-11-06 22:29 ` Viacheslav Dubeyko
2025-11-08 14:01 ` Theodore Ts'o [this message]
2025-11-10 19:41 ` Viacheslav Dubeyko
2025-11-11 1:53 ` Zorro Lang
2025-11-11 2:02 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251108140116.GB2988753@mit.edu \
--to=tytso@mit.edu \
--cc=Slava.Dubeyko@ibm.com \
--cc=frank.li@vivo.com \
--cc=fstests@vger.kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.