RE: [RFC] Why generic/073 is generic but not btrfs specific?

[Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>]

On Tue, 2025-11-11 at 09:53 +0800, Zorro Lang wrote:
> On Mon, Nov 10, 2025 at 07:41:40PM +0000, Viacheslav Dubeyko wrote:
> > On Sat, 2025-11-08 at 09:01 -0500, Theodore Ts'o wrote:
> > > On Thu, Nov 06, 2025 at 10:29:46PM +0000, Viacheslav Dubeyko wrote:
> > > > > > Technically speaking, HFS+ is journaling file system in Apple implementation.
> > > > > > But we don't have this functionality implemented and fully supported on Linux
> > > > > > kernel side. Potentially, it can be done but currently we haven't such
> > > > > > functionality yet. So, HFS/HFS+ doesn't use journaling on Linux kernel side  and
> > > > > > no journal replay could happen. :)
> > > 
> > > If the implementation of HJFJS+ in Linux doesn't support metadata
> > > consistency after a crash, I'd suggest adding HFS+ to
> > > _has_metadat_journalling().  This will suppress a number of test
> > > failures so you can focus on other issues which arguably is probably
> > > higher priority for you to fix.
> > > 
> > > After you get HFS+ to run clean with the journalling tesets skipped,
> > > then you can focus on adding that guarantee at that point, perhaps?
> > > 
> > > 
> > 
> > Yes, it makes sense. It's really good strategy. But I've decided to spend couple
> > of days on the fix of this issue. If I am not lucky to find the quick fix, then
> > I'll follow this strategy. :)
> 
> Hi Slava,
> 
> fstests doesn't have an offical HFS+ supporting report (refer to README), so if you
> find some helpers/cases can't work on hfs/hfsplus well, please feel free to modify
> them to support hfs/hfsplus, then add hfs/hfsplus to the supporting list (in README)
> after we make sure it works :)
> 

Hi Zorro,

Sounds good! I am working on it. Currently, I am trying to identify such test-
cases. I have several in mind but, currently, I am focused on test-cases that
require the fixes on HFS/HFS+ side.

I'll share the patches when I'll completely sure that HFS/HFS+ cannot manage
some xfstests cases.

Thanks,
Slava.