Re: [PATCH v2 1/4] Make enter_lazy_tlb inline on x86

[kernel test robot <lkp@intel.com>]

Hi Xie,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/x86/core tip/x86/mm s390/features perf-tools-next/perf-tools-next tip/perf/core perf-tools/perf-tools linus/master v6.18-rc4 next-20251107]
[cannot apply to acme/perf/core tip/timers/nohz]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xie-Yuanbin/Make-enter_lazy_tlb-inline-on-x86/20251109-013003
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20251108172346.263590-2-qq570070308%40gmail.com
patch subject: [PATCH v2 1/4] Make enter_lazy_tlb inline on x86
config: i386-randconfig-014-20251109 (https://download.01.org/0day-ci/archive/20251110/202511100042.ZklpqjOY-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251110/202511100042.ZklpqjOY-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511100042.ZklpqjOY-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/asm-generic/bug.h:5,
                    from arch/x86/include/asm/bug.h:108,
                    from include/linux/bug.h:5,
                    from include/linux/vfsdebug.h:5,
                    from include/linux/fs.h:5,
                    from include/linux/highmem.h:5,
                    from arch/x86/kvm/vmx/vmx.c:17:
   arch/x86/include/asm/mmu_context.h: In function 'enter_lazy_tlb':
>> arch/x86/include/asm/mmu_context.h:155:27: error: 'cpu_tlbstate' undeclared (first use in this function); did you mean 'cpuhp_state'?
     155 |         if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
         |                           ^~~~~~~~~~~~
   include/linux/compiler.h:244:47: note: in definition of macro 'TYPEOF_UNQUAL'
     244 | # define TYPEOF_UNQUAL(exp) __typeof_unqual__(exp)
         |                                               ^~~
   include/linux/percpu-defs.h:499:41: note: in expansion of macro '__pcpu_size_call_return'
     499 | #define this_cpu_read(pcp)              __pcpu_size_call_return(this_cpu_read_, pcp)
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/mmu_context.h:155:13: note: in expansion of macro 'this_cpu_read'
     155 |         if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
         |             ^~~~~~~~~~~~~
   arch/x86/include/asm/mmu_context.h:155:27: note: each undeclared identifier is reported only once for each function it appears in
     155 |         if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
         |                           ^~~~~~~~~~~~
   include/linux/compiler.h:244:47: note: in definition of macro 'TYPEOF_UNQUAL'
     244 | # define TYPEOF_UNQUAL(exp) __typeof_unqual__(exp)
         |                                               ^~~
   include/linux/percpu-defs.h:499:41: note: in expansion of macro '__pcpu_size_call_return'
     499 | #define this_cpu_read(pcp)              __pcpu_size_call_return(this_cpu_read_, pcp)
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~
   arch/x86/include/asm/mmu_context.h:155:13: note: in expansion of macro 'this_cpu_read'
     155 |         if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
         |             ^~~~~~~~~~~~~
   In file included from arch/x86/kvm/vmx/vmx.c:46:
   arch/x86/include/asm/mmu_context.h:155:51: warning: comparison between pointer and integer
     155 |         if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
         |                                                   ^~
   In file included from include/asm-generic/percpu.h:7,
                    from arch/x86/include/asm/percpu.h:597,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:79,
                    from include/linux/spinlock.h:56,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:7:
>> arch/x86/include/asm/mmu_context.h:158:24: error: 'cpu_tlbstate_shared' undeclared (first use in this function)
     158 |         this_cpu_write(cpu_tlbstate_shared.is_lazy, true);
         |                        ^~~~~~~~~~~~~~~~~~~
   include/linux/percpu-defs.h:221:54: note: in definition of macro '__verify_pcpu_ptr'
     221 |         const void __percpu *__vpp_verify = (typeof((ptr) + 0))NULL;    \
         |                                                      ^~~
   include/linux/percpu-defs.h:500:41: note: in expansion of macro '__pcpu_size_call'
     500 | #define this_cpu_write(pcp, val)        __pcpu_size_call(this_cpu_write_, pcp, val)
         |                                         ^~~~~~~~~~~~~~~~
   arch/x86/include/asm/mmu_context.h:158:9: note: in expansion of macro 'this_cpu_write'
     158 |         this_cpu_write(cpu_tlbstate_shared.is_lazy, true);
         |         ^~~~~~~~~~~~~~


vim +155 arch/x86/include/asm/mmu_context.h

   138	
   139	/*
   140	 * Please ignore the name of this function.  It should be called
   141	 * switch_to_kernel_thread().
   142	 *
   143	 * enter_lazy_tlb() is a hint from the scheduler that we are entering a
   144	 * kernel thread or other context without an mm.  Acceptable implementations
   145	 * include doing nothing whatsoever, switching to init_mm, or various clever
   146	 * lazy tricks to try to minimize TLB flushes.
   147	 *
   148	 * The scheduler reserves the right to call enter_lazy_tlb() several times
   149	 * in a row.  It will notify us that we're going back to a real mm by
   150	 * calling switch_mm_irqs_off().
   151	 */
   152	#define enter_lazy_tlb enter_lazy_tlb
   153	static __always_inline void enter_lazy_tlb(struct mm_struct *mm, struct task_struct *tsk)
   154	{
 > 155		if (this_cpu_read(cpu_tlbstate.loaded_mm) == &init_mm)
   156			return;
   157	
 > 158		this_cpu_write(cpu_tlbstate_shared.is_lazy, true);
   159	}
   160	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki