From: Peter Zijlstra <peterz@infradead.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Xie Yuanbin <qq570070308@gmail.com>,
david@redhat.com, tglx@linutronix.de, segher@kernel.crashing.org,
riel@surriel.com, linux@armlinux.org.uk,
mathieu.desnoyers@efficios.com, paulmck@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, davem@davemloft.net, andreas@gaisler.com,
luto@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, anna-maria@linutronix.de,
frederic@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
justinstitt@google.com, thuth@redhat.com, brauner@kernel.org,
arnd@arndb.de, jlayton@kernel.org, aalbersh@redhat.com,
akpm@linux-foundation.org, david@kernel.org,
lorenzo.stoakes@oracle.com, max.kellermann@ionos.com,
ryan.roberts@arm.com, nysal@linux.ibm.com, urezki@gmail.com,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-perf-users@vger.kernel.org, llvm@lists.linux.dev,
will@kernel.org
Subject: Re: [PATCH v2 3/4] Provide the always inline version of some functions
Date: Sun, 9 Nov 2025 12:51:52 +0100 [thread overview]
Message-ID: <20251109115152.GD2545891@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <04CA2D22-4DE2-4DE1-A2BC-AACE666F5F93@zytor.com>
On Sat, Nov 08, 2025 at 02:14:44PM -0800, H. Peter Anvin wrote:
> >+static struct rq *finish_task_switch(struct task_struct *prev)
> >+{
> >+ return finish_task_switch_ainline(prev);
> >+}
> >+
> > /**
> > * schedule_tail - first thing a freshly forked thread must call.
> > * @prev: the thread we just switched away from.
>
> There is, in fact: you have to have an always_inline version, and wrap it in a noinline version.
Yes, but all of this is particularly retarded, there are exactly _2_
callers of this function. Keeping an out-of-line copy for one while
inlineing the other makes 0 sense.
Also, the amount of crap he needs to mark __always_inline doesn't make
much sense to me, is he building with -Os or something?
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Xie Yuanbin <qq570070308@gmail.com>,
david@redhat.com, tglx@linutronix.de, segher@kernel.crashing.org,
riel@surriel.com, linux@armlinux.org.uk,
mathieu.desnoyers@efficios.com, paulmck@kernel.org,
pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu,
alex@ghiti.fr, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, davem@davemloft.net, andreas@gaisler.com,
luto@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
james.clark@linaro.org, anna-maria@linutronix.de,
frederic@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, nathan@kernel.org,
nick.desaulniers+lkml@gmail.com, morbo@google.com,
justinstitt@google.com, thuth@redhat.com, brauner@kernel.org,
arnd@arndb.de, jlayton@kernel.org, aalbersh@redhat.com,
akpm@linux-foundation.org, david@kernel.org,
lorenzo.stoakes@oracle.com, max.kellermann@ionos.com,
ryan.roberts@arm.com, nysal@linux.ibm.com, urezki@gmail.com,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-perf-users@vger.kernel.org, llvm@lists.linux.dev,
will@kernel.org
Subject: Re: [PATCH v2 3/4] Provide the always inline version of some functions
Date: Sun, 9 Nov 2025 12:51:52 +0100 [thread overview]
Message-ID: <20251109115152.GD2545891@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <04CA2D22-4DE2-4DE1-A2BC-AACE666F5F93@zytor.com>
On Sat, Nov 08, 2025 at 02:14:44PM -0800, H. Peter Anvin wrote:
> >+static struct rq *finish_task_switch(struct task_struct *prev)
> >+{
> >+ return finish_task_switch_ainline(prev);
> >+}
> >+
> > /**
> > * schedule_tail - first thing a freshly forked thread must call.
> > * @prev: the thread we just switched away from.
>
> There is, in fact: you have to have an always_inline version, and wrap it in a noinline version.
Yes, but all of this is particularly retarded, there are exactly _2_
callers of this function. Keeping an out-of-line copy for one while
inlineing the other makes 0 sense.
Also, the amount of crap he needs to mark __always_inline doesn't make
much sense to me, is he building with -Os or something?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-11-09 11:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 17:23 [PATCH v2 0/4] Optimize code generation during context switching Xie Yuanbin
2025-11-08 17:23 ` Xie Yuanbin
2025-11-08 17:23 ` [PATCH v2 1/4] Make enter_lazy_tlb inline on x86 Xie Yuanbin
2025-11-08 17:23 ` Xie Yuanbin
2025-11-09 12:20 ` kernel test robot
2025-11-09 14:42 ` kernel test robot
2025-11-09 16:56 ` kernel test robot
2025-11-08 17:23 ` [PATCH v2 2/4] Make raw_spin_rq_unlock inline Xie Yuanbin
2025-11-08 17:23 ` Xie Yuanbin
2025-11-08 17:23 ` [PATCH v2 3/4] Provide the always inline version of some functions Xie Yuanbin
2025-11-08 17:23 ` Xie Yuanbin
2025-11-08 22:14 ` H. Peter Anvin
2025-11-08 22:14 ` H. Peter Anvin
2025-11-09 11:51 ` Peter Zijlstra [this message]
2025-11-09 11:51 ` Peter Zijlstra
2025-11-10 23:21 ` H. Peter Anvin
2025-11-10 23:21 ` H. Peter Anvin
2025-11-09 11:31 ` Peter Zijlstra
2025-11-09 11:31 ` Peter Zijlstra
2025-11-09 17:04 ` Xie Yuanbin
2025-11-09 17:04 ` Xie Yuanbin
2025-11-09 17:35 ` Arnd Bergmann
2025-11-09 17:35 ` Arnd Bergmann
2025-11-10 15:43 ` Xie Yuanbin
2025-11-10 15:43 ` Xie Yuanbin
2025-11-08 17:23 ` [PATCH v2 4/4] Make finish_task_switch and its subfuncs inline in context switching Xie Yuanbin
2025-11-08 17:23 ` Xie Yuanbin
2025-11-09 11:35 ` Peter Zijlstra
2025-11-09 11:35 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251109115152.GD2545891@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aalbersh@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=alexander.shishkin@linux.intel.com \
--cc=andreas@gaisler.com \
--cc=anna-maria@linutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=bsegall@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=david@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jlayton@kernel.org \
--cc=jolsa@kernel.org \
--cc=juri.lelli@redhat.com \
--cc=justinstitt@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=max.kellermann@ionos.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nysal@linux.ibm.com \
--cc=palmer@dabbelt.com \
--cc=paulmck@kernel.org \
--cc=pjw@kernel.org \
--cc=qq570070308@gmail.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=segher@kernel.crashing.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=thuth@redhat.com \
--cc=urezki@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.