All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miguel Ojeda <ojeda@kernel.org>
To: Miguel Ojeda <ojeda@kernel.org>,
	Alex Gaynor <alex.gaynor@gmail.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas@fjasle.eu>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Danilo Krummrich" <dakr@kernel.org>,
	rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: [PATCH 01/18] rust: condvar: avoid `pub` in example
Date: Mon, 10 Nov 2025 10:50:06 +0100	[thread overview]
Message-ID: <20251110095025.1475896-2-ojeda@kernel.org> (raw)
In-Reply-To: <20251110095025.1475896-1-ojeda@kernel.org>

The future move of pin-init to `syn` uncovers the following unreachable
public item in an example:

    error: unreachable `pub` item
         --> rust/doctests_kernel_generated.rs:14683:1
          |
    14683 | pub struct Example {
          | ---^^^^^^^^^^^^^^^
          | |
          | help: consider restricting its visibility: `pub(crate)`
          |
          = help: or consider exporting it for use by other crates
          = note: `-D unreachable-pub` implied by `-D warnings`
          = help: to override `-D warnings` add `#[allow(unreachable_pub)]`

There is no real downside of keeping the example as-is until the
`syn`-based pin-init is introduced, so there is no need to treat it as
a fix nor to backport it. However, we still need to change it before
introducing the new pin-init.

Thus do so.

Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
 rust/kernel/sync/condvar.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/sync/condvar.rs b/rust/kernel/sync/condvar.rs
index aa5b9a7a726d..1e66e9f548a3 100644
--- a/rust/kernel/sync/condvar.rs
+++ b/rust/kernel/sync/condvar.rs
@@ -46,7 +46,7 @@ macro_rules! new_condvar {
 /// use kernel::sync::{new_condvar, new_mutex, CondVar, Mutex};
 ///
 /// #[pin_data]
-/// pub struct Example {
+/// struct Example {
 ///     #[pin]
 ///     value: Mutex<u32>,
 ///
-- 
2.51.2


  reply	other threads:[~2025-11-10  9:51 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-10  9:50 [PATCH 00/18] `syn` support Miguel Ojeda
2025-11-10  9:50 ` Miguel Ojeda [this message]
2025-11-10 10:24   ` [PATCH 01/18] rust: condvar: avoid `pub` in example Alice Ryhl
2025-11-10 11:10     ` Miguel Ojeda
2025-11-10  9:50 ` [PATCH 02/18] rust: kbuild: introduce `core-flags` and `core-skip_flags` Miguel Ojeda
2025-11-10 10:19   ` Miguel Ojeda
2025-11-10 11:50     ` Alice Ryhl
2025-11-10 10:27   ` Alice Ryhl
2025-11-10 19:18   ` John Hubbard
2025-11-12 11:13     ` Miguel Ojeda
2025-11-10  9:50 ` [PATCH 03/18] rust: kbuild: simplify `--cfg` handling Miguel Ojeda
2025-11-10 10:33   ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 04/18] rust: kbuild: add host library support Miguel Ojeda
2025-11-10 10:43   ` Alice Ryhl
2025-11-10 11:17     ` Miguel Ojeda
2025-11-10  9:50 ` [PATCH 05/18] rust: proc-macro2: import crate Miguel Ojeda
2025-11-10  9:50 ` [PATCH 06/18] rust: proc-macro2: add SPDX License Identifiers Miguel Ojeda
2025-11-10  9:50 ` [PATCH 07/18] rust: proc-macro2: remove `unicode_ident` dependency Miguel Ojeda
2025-11-10 10:50   ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 08/18] rust: proc-macro2: add `README.md` Miguel Ojeda
2025-11-10 10:52   ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 09/18] rust: proc-macro2: enable support in kbuild Miguel Ojeda
2025-11-10 11:38   ` Alice Ryhl
2025-11-10 13:10     ` Gary Guo
2025-11-10 13:28       ` Miguel Ojeda
2025-11-10 13:34         ` Alice Ryhl
2025-11-10 19:34   ` John Hubbard
2025-11-12 11:14     ` Miguel Ojeda
2025-11-24 19:36       ` John Hubbard
2025-11-24 20:00         ` Miguel Ojeda
2025-11-24 20:21           ` John Hubbard
2025-11-10  9:50 ` [PATCH 10/18] rust: quote: import crate Miguel Ojeda
2025-11-10  9:50 ` [PATCH 11/18] rust: quote: add SPDX License Identifiers Miguel Ojeda
2025-11-10  9:50 ` [PATCH 12/18] rust: quote: add `README.md` Miguel Ojeda
2025-11-10  9:50 ` [PATCH 13/18] rust: quote: enable support in kbuild Miguel Ojeda
2025-11-10 11:44   ` Alice Ryhl
2025-11-10 13:13     ` Gary Guo
2025-11-10 13:22       ` Miguel Ojeda
2025-11-10 13:35         ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 14/18] rust: syn: import crate Miguel Ojeda
2025-11-10 10:26   ` Miguel Ojeda
2025-11-10  9:50 ` [PATCH 15/18] rust: syn: add SPDX License Identifiers Miguel Ojeda
2025-11-10  9:50 ` [PATCH 16/18] rust: syn: remove `unicode-ident` dependency Miguel Ojeda
2025-11-10 11:47   ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 17/18] rust: syn: add `README.md` Miguel Ojeda
2025-11-10 11:47   ` Alice Ryhl
2025-11-10  9:50 ` [PATCH 18/18] rust: syn: enable support in kbuild Miguel Ojeda
2025-11-10 11:49   ` Alice Ryhl
2025-11-10 13:38     ` Miguel Ojeda
2025-11-10 13:42       ` Alice Ryhl
2025-11-10 19:43   ` John Hubbard
2025-11-10 13:59 ` [PATCH 00/18] `syn` support Gary Guo
2025-11-10 14:20   ` Miguel Ojeda
2025-11-21  4:37   ` Jesung Yang
2025-11-21  5:36     ` Miguel Ojeda
2025-11-21  9:08       ` Jesung Yang
2025-11-23 12:50         ` Miguel Ojeda
2025-11-23 22:46           ` Jesung Yang
2025-11-10 15:59 ` Jonathan Corbet
2025-11-10 16:27   ` Miguel Ojeda
2025-11-10 17:04     ` Benno Lossin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110095025.1475896-2-ojeda@kernel.org \
    --to=ojeda@kernel.org \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=patches@lists.linux.dev \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.