From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: "Alex Gaynor" <alex.gaynor@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nicolas@fjasle.eu>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH 03/18] rust: kbuild: simplify `--cfg` handling
Date: Mon, 10 Nov 2025 10:33:36 +0000 [thread overview]
Message-ID: <aRG_gJu_yZeJWPuo@google.com> (raw)
In-Reply-To: <20251110095025.1475896-4-ojeda@kernel.org>
On Mon, Nov 10, 2025 at 10:50:08AM +0100, Miguel Ojeda wrote:
> We need to handle `cfg`s in both `rustc` and `rust-analyzer`, and in
> future commits some of those contain double quotes, which complicates
> things further.
>
> Thus, instead of removing the `--cfg ` part in the rust-analyzer
> generation script, have the `*-cfgs` variables contain just the actual
> `cfg`, and use that to generate the actual flags in `*-flags`.
>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
For anyone else reviewing this, here is the relevant part of the
makefile that calls generate_rust_analyzer:
rust-analyzer:
$(Q)MAKEFLAGS= $(srctree)/scripts/generate_rust_analyzer.py \
--cfgs='core=$(core-cfgs)' $(core-edition) \
$(realpath $(srctree)) $(realpath $(objtree)) \
$(rustc_sysroot) $(RUST_LIB_SRC) $(if $(KBUILD_EXTMOD),$(srcroot)) \
> rust-project.json
next prev parent reply other threads:[~2025-11-10 10:33 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 9:50 [PATCH 00/18] `syn` support Miguel Ojeda
2025-11-10 9:50 ` [PATCH 01/18] rust: condvar: avoid `pub` in example Miguel Ojeda
2025-11-10 10:24 ` Alice Ryhl
2025-11-10 11:10 ` Miguel Ojeda
2025-11-10 9:50 ` [PATCH 02/18] rust: kbuild: introduce `core-flags` and `core-skip_flags` Miguel Ojeda
2025-11-10 10:19 ` Miguel Ojeda
2025-11-10 11:50 ` Alice Ryhl
2025-11-10 10:27 ` Alice Ryhl
2025-11-10 19:18 ` John Hubbard
2025-11-12 11:13 ` Miguel Ojeda
2025-11-10 9:50 ` [PATCH 03/18] rust: kbuild: simplify `--cfg` handling Miguel Ojeda
2025-11-10 10:33 ` Alice Ryhl [this message]
2025-11-10 9:50 ` [PATCH 04/18] rust: kbuild: add host library support Miguel Ojeda
2025-11-10 10:43 ` Alice Ryhl
2025-11-10 11:17 ` Miguel Ojeda
2025-11-10 9:50 ` [PATCH 05/18] rust: proc-macro2: import crate Miguel Ojeda
2025-11-10 9:50 ` [PATCH 06/18] rust: proc-macro2: add SPDX License Identifiers Miguel Ojeda
2025-11-10 9:50 ` [PATCH 07/18] rust: proc-macro2: remove `unicode_ident` dependency Miguel Ojeda
2025-11-10 10:50 ` Alice Ryhl
2025-11-10 9:50 ` [PATCH 08/18] rust: proc-macro2: add `README.md` Miguel Ojeda
2025-11-10 10:52 ` Alice Ryhl
2025-11-10 9:50 ` [PATCH 09/18] rust: proc-macro2: enable support in kbuild Miguel Ojeda
2025-11-10 11:38 ` Alice Ryhl
2025-11-10 13:10 ` Gary Guo
2025-11-10 13:28 ` Miguel Ojeda
2025-11-10 13:34 ` Alice Ryhl
2025-11-10 19:34 ` John Hubbard
2025-11-12 11:14 ` Miguel Ojeda
2025-11-24 19:36 ` John Hubbard
2025-11-24 20:00 ` Miguel Ojeda
2025-11-24 20:21 ` John Hubbard
2025-11-10 9:50 ` [PATCH 10/18] rust: quote: import crate Miguel Ojeda
2025-11-10 9:50 ` [PATCH 11/18] rust: quote: add SPDX License Identifiers Miguel Ojeda
2025-11-10 9:50 ` [PATCH 12/18] rust: quote: add `README.md` Miguel Ojeda
2025-11-10 9:50 ` [PATCH 13/18] rust: quote: enable support in kbuild Miguel Ojeda
2025-11-10 11:44 ` Alice Ryhl
2025-11-10 13:13 ` Gary Guo
2025-11-10 13:22 ` Miguel Ojeda
2025-11-10 13:35 ` Alice Ryhl
2025-11-10 9:50 ` [PATCH 14/18] rust: syn: import crate Miguel Ojeda
2025-11-10 10:26 ` Miguel Ojeda
2025-11-10 9:50 ` [PATCH 15/18] rust: syn: add SPDX License Identifiers Miguel Ojeda
2025-11-10 9:50 ` [PATCH 16/18] rust: syn: remove `unicode-ident` dependency Miguel Ojeda
2025-11-10 11:47 ` Alice Ryhl
2025-11-10 9:50 ` [PATCH 17/18] rust: syn: add `README.md` Miguel Ojeda
2025-11-10 11:47 ` Alice Ryhl
2025-11-10 9:50 ` [PATCH 18/18] rust: syn: enable support in kbuild Miguel Ojeda
2025-11-10 11:49 ` Alice Ryhl
2025-11-10 13:38 ` Miguel Ojeda
2025-11-10 13:42 ` Alice Ryhl
2025-11-10 19:43 ` John Hubbard
2025-11-10 13:59 ` [PATCH 00/18] `syn` support Gary Guo
2025-11-10 14:20 ` Miguel Ojeda
2025-11-21 4:37 ` Jesung Yang
2025-11-21 5:36 ` Miguel Ojeda
2025-11-21 9:08 ` Jesung Yang
2025-11-23 12:50 ` Miguel Ojeda
2025-11-23 22:46 ` Jesung Yang
2025-11-10 15:59 ` Jonathan Corbet
2025-11-10 16:27 ` Miguel Ojeda
2025-11-10 17:04 ` Benno Lossin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRG_gJu_yZeJWPuo@google.com \
--to=aliceryhl@google.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=ojeda@kernel.org \
--cc=patches@lists.linux.dev \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.