All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Yixun Lan <dlan@gentoo.org>, Alex Elder <elder@riscstar.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-i2c@vger.kernel.org,
	linux-rtc@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: (subset) [PATCH v2 1/4] mfd: simple-mfd-i2c: remove select I2C_K1
Date: Mon, 10 Nov 2025 13:45:50 +0000	[thread overview]
Message-ID: <20251110134550.GE1949330@google.com> (raw)
In-Reply-To: <71DB25E553BE0B04+aQ1LlKzeR-FkZA83@kernel.org>

On Fri, 07 Nov 2025, Troy Mitchell wrote:

> On Thu, Nov 06, 2025 at 04:04:21PM +0000, Lee Jones wrote:
> > On Mon, 27 Oct 2025 13:48:05 +0800, Troy Mitchell wrote:
> > > select will force a symbol to a specific value without considering
> > > its dependencies. As a result, the i2c-k1 driver will fail to build
> > > when OF or COMMON_CLK are disabled.
> > > 
> > > The reason for removing I2C_K1 instead of adding a depends on condition
> > > is to keep the possibility for other SoCs to use this PMIC.
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/4] mfd: simple-mfd-i2c: remove select I2C_K1
> >       commit: ecf6bc474ae97c404e2125b413eb0ef3627b03c5
> Hi Lee,
> 
> I think you didn't notice this reply [1]
> (Maybe because he was replying to the cover letter).
> 
> As Aurelien mentioned, the current shutdown/reboot (and possibly the regulator
> as well) intends to use the `default MFD_SPACEMIT_P1`.
> So if there’s no `default m if ARCH_SPACEMIT`,
> the default value in subdevices may not make much sense.
> 
> But don’t worry — to make things easier for you, I’ll send an additional
> patch based on your branch (in this series).
> 
> How does that sound?

Go for it.

-- 
Lee Jones [李琼斯]

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Yixun Lan <dlan@gentoo.org>, Alex Elder <elder@riscstar.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-i2c@vger.kernel.org,
	linux-rtc@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: (subset) [PATCH v2 1/4] mfd: simple-mfd-i2c: remove select I2C_K1
Date: Mon, 10 Nov 2025 13:45:50 +0000	[thread overview]
Message-ID: <20251110134550.GE1949330@google.com> (raw)
In-Reply-To: <71DB25E553BE0B04+aQ1LlKzeR-FkZA83@kernel.org>

On Fri, 07 Nov 2025, Troy Mitchell wrote:

> On Thu, Nov 06, 2025 at 04:04:21PM +0000, Lee Jones wrote:
> > On Mon, 27 Oct 2025 13:48:05 +0800, Troy Mitchell wrote:
> > > select will force a symbol to a specific value without considering
> > > its dependencies. As a result, the i2c-k1 driver will fail to build
> > > when OF or COMMON_CLK are disabled.
> > > 
> > > The reason for removing I2C_K1 instead of adding a depends on condition
> > > is to keep the possibility for other SoCs to use this PMIC.
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [1/4] mfd: simple-mfd-i2c: remove select I2C_K1
> >       commit: ecf6bc474ae97c404e2125b413eb0ef3627b03c5
> Hi Lee,
> 
> I think you didn't notice this reply [1]
> (Maybe because he was replying to the cover letter).
> 
> As Aurelien mentioned, the current shutdown/reboot (and possibly the regulator
> as well) intends to use the `default MFD_SPACEMIT_P1`.
> So if there’s no `default m if ARCH_SPACEMIT`,
> the default value in subdevices may not make much sense.
> 
> But don’t worry — to make things easier for you, I’ll send an additional
> patch based on your branch (in this series).
> 
> How does that sound?

Go for it.

-- 
Lee Jones [李琼斯]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2025-11-10 13:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  5:48 [PATCH v2 0/4] fix the SpacemiT P1 Kconfig and resend the K1 I2C ILCR patch Troy Mitchell
2025-10-27  5:48 ` Troy Mitchell
2025-10-27  5:48 ` [PATCH v2 1/4] mfd: simple-mfd-i2c: remove select I2C_K1 Troy Mitchell
2025-10-27  5:48   ` Troy Mitchell
2025-11-06 16:04   ` (subset) " Lee Jones
2025-11-06 16:04     ` Lee Jones
2025-11-07  1:29     ` Troy Mitchell
2025-11-07  1:29       ` Troy Mitchell
2025-11-10 13:45       ` Lee Jones [this message]
2025-11-10 13:45         ` Lee Jones
2025-10-27  5:48 ` [PATCH v2 2/4] i2c: spacemit: configure ILCR for accurate SCL frequency Troy Mitchell
2025-10-27  5:48   ` Troy Mitchell
2025-11-12  6:14   ` Troy Mitchell
2025-11-12  6:14     ` Troy Mitchell
2025-10-27  5:48 ` [PATCH v2 3/4] rtc: spacemit: MFD_SPACEMIT_P1 as dependencies Troy Mitchell
2025-10-27  5:48   ` Troy Mitchell
2025-10-27  5:48 ` [PATCH v2 4/4] regulator: " Troy Mitchell
2025-10-27  5:48   ` Troy Mitchell
2025-10-27 12:08   ` Mark Brown
2025-10-27 12:08     ` Mark Brown
2025-10-27 10:24 ` [PATCH v2 0/4] fix the SpacemiT P1 Kconfig and resend the K1 I2C ILCR patch Aurelien Jarno
2025-10-27 10:24   ` Aurelien Jarno
2025-10-27 13:52   ` Troy Mitchell
2025-10-27 13:52     ` Troy Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251110134550.GE1949330@google.com \
    --to=lee@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andi.shyti@kernel.org \
    --cc=broonie@kernel.org \
    --cc=dlan@gentoo.org \
    --cc=elder@riscstar.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.