From: Boris Brezillon <boris.brezillon@collabora.com>
To: Philipp Stanner <pstanner@redhat.com>
Cc: "Steven Price" <steven.price@arm.com>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Adrián Larumbe" <adrian.larumbe@collabora.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org,
"Detlev Casanova" <detlev.casanova@collabora.com>,
"Ashley Smith" <ashley.smith@collabora.com>,
kernel@collabora.com
Subject: Re: [PATCH v7 1/2] drm/panthor: Make the timeout per-queue instead of per-job
Date: Wed, 12 Nov 2025 15:23:40 +0100 [thread overview]
Message-ID: <20251112152340.40f72b7e@fedora> (raw)
In-Reply-To: <20251112151253.7cfba768@fedora>
On Wed, 12 Nov 2025 15:12:53 +0100
Boris Brezillon <boris.brezillon@collabora.com> wrote:
> > OK. timeout_wq sharing is intended and allowed, so if that's what
> > you're doing, good. But I agree that accessing the wq through the
> > driver's struct is then cleaner and more obviously correct.
>
> Will do.
Actually, after looking into that, it seems I'd have to go back to
dev_get_drvdata(drm_gpu_scheduler::dev)::reset_wq to get the timeout
workqueue, so I think I'd prefer to keep using
drm_gpu_scheduler::timeout_wq unless that's really seen as a layering
violation (but I'd argue that accessing drm_gpu_scheduler::dev looks
like the same kind of layering violation to me).
next prev parent reply other threads:[~2025-11-12 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 12:17 [PATCH v7 0/2] drm/panthor: Scheduler fixes for termination failure and timeouts Boris Brezillon
2025-11-12 12:17 ` [PATCH v7 1/2] drm/panthor: Make the timeout per-queue instead of per-job Boris Brezillon
2025-11-12 12:38 ` Philipp Stanner
2025-11-12 13:31 ` Boris Brezillon
2025-11-12 13:48 ` Philipp Stanner
2025-11-12 14:12 ` Boris Brezillon
2025-11-12 14:23 ` Boris Brezillon [this message]
2025-11-13 10:56 ` Philipp Stanner
2025-11-13 11:05 ` Boris Brezillon
2025-11-12 12:17 ` [PATCH v7 2/2] drm/panthor: Reset queue slots if termination fails Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251112152340.40f72b7e@fedora \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=ashley.smith@collabora.com \
--cc=detlev.casanova@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=pstanner@redhat.com \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.