From: Jiri Olsa <jolsa@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH 1/5] x86/insn-eval: Remove regs arg from pt_regs_offset
Date: Mon, 17 Nov 2025 10:31:33 +0100 [thread overview]
Message-ID: <20251117093137.572132-2-jolsa@kernel.org> (raw)
In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org>
It's not used, pt_regs_offset returns only offset to struct pt_regs,
not the actual register values.
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
arch/x86/include/asm/insn-eval.h | 2 +-
arch/x86/lib/insn-eval.c | 4 ++--
arch/x86/mm/extable.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/include/asm/insn-eval.h b/arch/x86/include/asm/insn-eval.h
index 4733e9064ee5..6b592040bda4 100644
--- a/arch/x86/include/asm/insn-eval.h
+++ b/arch/x86/include/asm/insn-eval.h
@@ -15,7 +15,7 @@
#define INSN_CODE_SEG_OPND_SZ(params) (params & 0xf)
#define INSN_CODE_SEG_PARAMS(oper_sz, addr_sz) (oper_sz | (addr_sz << 4))
-int pt_regs_offset(struct pt_regs *regs, int regno);
+int pt_regs_offset(int regno);
bool insn_has_rep_prefix(struct insn *insn);
void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs);
diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c
index e03eeec55cfe..7b46eb717066 100644
--- a/arch/x86/lib/insn-eval.c
+++ b/arch/x86/lib/insn-eval.c
@@ -437,7 +437,7 @@ static const int pt_regoff[] = {
#endif
};
-int pt_regs_offset(struct pt_regs *regs, int regno)
+int pt_regs_offset(int regno)
{
if ((unsigned)regno < ARRAY_SIZE(pt_regoff))
return pt_regoff[regno];
@@ -527,7 +527,7 @@ static int get_reg_offset(struct insn *insn, struct pt_regs *regs,
if (regno < 0)
return regno;
- return pt_regs_offset(regs, regno);
+ return pt_regs_offset(regno);
}
/**
diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
index 2fdc1f1f5adb..b9a34de9181d 100644
--- a/arch/x86/mm/extable.c
+++ b/arch/x86/mm/extable.c
@@ -15,7 +15,7 @@
static inline unsigned long *pt_regs_nr(struct pt_regs *regs, int nr)
{
- int reg_offset = pt_regs_offset(regs, nr);
+ int reg_offset = pt_regs_offset(nr);
static unsigned long __dummy;
if (WARN_ON_ONCE(reg_offset < 0))
--
2.51.1
next prev parent reply other threads:[~2025-11-17 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:31 [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions Jiri Olsa
2025-11-17 9:31 ` Jiri Olsa [this message]
2025-11-17 9:31 ` [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg_offset Jiri Olsa
2025-11-17 9:31 ` [PATCH 3/5] x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off Jiri Olsa
2025-11-17 9:31 ` [PATCH 4/5] x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off Jiri Olsa
2025-11-17 9:31 ` [PATCH 5/5] x86/insn-eval: Remove regs arg from get_reg_offset_16 Jiri Olsa
2025-11-18 8:47 ` [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251117093137.572132-2-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.