All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>
Subject: [PATCH 2/5] x86/insn-eval: Remove regs arg from get_reg_offset
Date: Mon, 17 Nov 2025 10:31:34 +0100	[thread overview]
Message-ID: <20251117093137.572132-3-jolsa@kernel.org> (raw)
In-Reply-To: <20251117093137.572132-1-jolsa@kernel.org>

It's not used, get_reg_offset returns only offset to struct pt_regs,
not the actual register values.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 arch/x86/lib/insn-eval.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c
index 7b46eb717066..8b9c2b90d66e 100644
--- a/arch/x86/lib/insn-eval.c
+++ b/arch/x86/lib/insn-eval.c
@@ -519,8 +519,7 @@ static int get_regno(struct insn *insn, enum reg_type type)
 	return regno;
 }
 
-static int get_reg_offset(struct insn *insn, struct pt_regs *regs,
-			  enum reg_type type)
+static int get_reg_offset(struct insn *insn, enum reg_type type)
 {
 	int regno = get_regno(insn, type);
 
@@ -861,7 +860,7 @@ int insn_get_code_seg_params(struct pt_regs *regs)
  */
 int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs)
 {
-	return get_reg_offset(insn, regs, REG_TYPE_RM);
+	return get_reg_offset(insn, REG_TYPE_RM);
 }
 
 /**
@@ -876,7 +875,7 @@ int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs)
  */
 int insn_get_modrm_reg_off(struct insn *insn, struct pt_regs *regs)
 {
-	return get_reg_offset(insn, regs, REG_TYPE_REG);
+	return get_reg_offset(insn, REG_TYPE_REG);
 }
 
 /**
@@ -982,7 +981,7 @@ static int get_eff_addr_reg(struct insn *insn, struct pt_regs *regs,
 	if (X86_MODRM_MOD(insn->modrm.value) != 3)
 		return -EINVAL;
 
-	*regoff = get_reg_offset(insn, regs, REG_TYPE_RM);
+	*regoff = get_reg_offset(insn, REG_TYPE_RM);
 	if (*regoff < 0)
 		return -EINVAL;
 
@@ -1035,7 +1034,7 @@ static int get_eff_addr_modrm(struct insn *insn, struct pt_regs *regs,
 	if (X86_MODRM_MOD(insn->modrm.value) > 2)
 		return -EINVAL;
 
-	*regoff = get_reg_offset(insn, regs, REG_TYPE_RM);
+	*regoff = get_reg_offset(insn, REG_TYPE_RM);
 
 	/*
 	 * -EDOM means that we must ignore the address_offset. In such a case,
@@ -1181,8 +1180,8 @@ static int get_eff_addr_sib(struct insn *insn, struct pt_regs *regs,
 	if (!insn->sib.nbytes)
 		return -EINVAL;
 
-	*base_offset = get_reg_offset(insn, regs, REG_TYPE_BASE);
-	indx_offset = get_reg_offset(insn, regs, REG_TYPE_INDEX);
+	*base_offset = get_reg_offset(insn, REG_TYPE_BASE);
+	indx_offset = get_reg_offset(insn, REG_TYPE_INDEX);
 
 	/*
 	 * Negative values in the base and index offset means an error when
-- 
2.51.1


  parent reply	other threads:[~2025-11-17  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  9:31 [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions Jiri Olsa
2025-11-17  9:31 ` [PATCH 1/5] x86/insn-eval: Remove regs arg from pt_regs_offset Jiri Olsa
2025-11-17  9:31 ` Jiri Olsa [this message]
2025-11-17  9:31 ` [PATCH 3/5] x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off Jiri Olsa
2025-11-17  9:31 ` [PATCH 4/5] x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off Jiri Olsa
2025-11-17  9:31 ` [PATCH 5/5] x86/insn-eval: Remove regs arg from get_reg_offset_16 Jiri Olsa
2025-11-18  8:47 ` [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251117093137.572132-3-jolsa@kernel.org \
    --to=jolsa@kernel.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.