Re: [PATCH RFC 2/2] mm/cma: Consolidate accounting in dedicated functions

[SeongJae Park <sj@kernel.org>]

On Mon, 17 Nov 2025 12:15:02 +0100 Jean Delvare <jdelvare@suse.de> wrote:

> Move all accounting to dedicated functions and rename them
> accordingly.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>

Reviewed-by: SeongJae Park <sj@kernel.org>

> ---
> This is based on a suggestion by SeongJae Park. Comments welcome.
> 
>  mm/cma.c |   43 ++++++++++++++++++-------------------------
>  1 file changed, 18 insertions(+), 25 deletions(-)
> 
> --- linux-6.17.orig/mm/cma.c
> +++ linux-6.17/mm/cma.c
[...]
> @@ -1029,7 +1022,7 @@ bool cma_release(struct cma *cma, const
>  
>  	free_contig_range(pfn, count);
>  	cma_clear_bitmap(cma, cmr, pfn, count);
> -	cma_sysfs_account_release_pages(cma, count);
> +	cma_account_release(cma, count);
>  	trace_cma_release(cma->name, pfn, pages, count);

I was thinking we could further move trace_*() function calls to the new
functions, but this version also looks good to me.


Thanks,
SJ

[...]