All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Jean Delvare <jdelvare@suse.de>, linux-mm@kvack.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	Oscar Salvador <osalvador@suse.de>, SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH v2 1/2] mm/cma: Inline cma_sysfs counter hooks
Date: Mon, 17 Nov 2025 12:22:17 +0100	[thread overview]
Message-ID: <f3ec2046-3e8d-46a4-ac37-dc8e09f451ab@kernel.org> (raw)
In-Reply-To: <20251117115602.7b9c7ccd@endymion>

On 17.11.25 11:56, Jean Delvare wrote:
> Move cma_sysfs counter hooks from cma_sysfs.c to cma.c. These
> one-liner functions are only used once each, but the compiler
> currently can't inline them because they are defined in one object and
> used in another. Letting the compiler inline these functions lowers
> the footprint and runtime cost of the sysfs interface to CMA stats
> even more.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---

I would have moved them to the header, but no strong opinion

Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>

-- 
Cheers

David


  parent reply	other threads:[~2025-11-17 11:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 10:56 [PATCH v2 1/2] mm/cma: Inline cma_sysfs counter hooks Jean Delvare
2025-11-17 11:15 ` [PATCH RFC 2/2] mm/cma: Consolidate accounting in dedicated functions Jean Delvare
2025-11-18  1:40   ` SeongJae Park
2025-11-17 11:22 ` David Hildenbrand (Red Hat) [this message]
2025-11-18  1:34 ` [PATCH v2 1/2] mm/cma: Inline cma_sysfs counter hooks SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3ec2046-3e8d-46a4-ac37-dc8e09f451ab@kernel.org \
    --to=david@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.