[PATCH v1] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT

[PATCH v1] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT

[Ernest Van Hoecke]

From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

In TEZI (Toradex Easy Installer), we use one U-Boot binary for both our
NAND and eMMC Colibri iMX7 modules. Currently, CONFIG_PREBOOT sets the
environment variable 'fdtfile' depending on which defconfig was used,
adding the '-emmc' variant for the emmc defconfig. Since we always build
the TEZI recovery U-Boot with the standard (non-emmc) defconfig, fdtfile
has to be overwritten later or it will be wrong there.

By using '$variant', the fdtfile var is properly constructed at run time
for both the NAND and eMMC variants, and we do not have to worry about
setting fdtfile again when building the recovery TEZI U-Boot.

This also synchronizes these configs with how we handle the iMX6ULL.

Fixes: 327381e8b57c ("colibri_imx7: use preboot for fdtfile evaluation")
Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
---
 configs/colibri_imx7_defconfig      | 2 +-
 configs/colibri_imx7_emmc_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configs/colibri_imx7_defconfig b/configs/colibri_imx7_defconfig
index 5a415120bead..ec950c89569e 100644
--- a/configs/colibri_imx7_defconfig
+++ b/configs/colibri_imx7_defconfig
@@ -22,7 +22,7 @@ CONFIG_BOOTDELAY=1
 CONFIG_OF_ENV_SETUP=y
 CONFIG_BOOTCOMMAND="run ubiboot ; echo ; echo ubiboot failed ; run distro_bootcmd;"
 CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="test -n ${fdtfile} || setenv fdtfile ${soc}-colibri-${fdt_board}.dtb "
+CONFIG_PREBOOT="test -n ${fdtfile} || setenv fdtfile imx7-colibri${variant}-${fdt_board}.dtb "
 CONFIG_SYS_PBSIZE=544
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 # CONFIG_DISPLAY_BOARDINFO is not set
diff --git a/configs/colibri_imx7_emmc_defconfig b/configs/colibri_imx7_emmc_defconfig
index bae43fe45aa7..8b8e71b056fc 100644
--- a/configs/colibri_imx7_emmc_defconfig
+++ b/configs/colibri_imx7_emmc_defconfig
@@ -19,7 +19,7 @@ CONFIG_FIT_VERBOSE=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_PREBOOT=y
-CONFIG_PREBOOT="test -n ${fdtfile} || setenv fdtfile ${soc}-colibri-emmc-${fdt_board}.dtb"
+CONFIG_PREBOOT="test -n ${fdtfile} || setenv fdtfile imx7-colibri${variant}-${fdt_board}.dtb"
 CONFIG_SYS_PBSIZE=544
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
 # CONFIG_DISPLAY_BOARDINFO is not set
-- 
2.43.0

Re: [PATCH v1] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT

[Francesco Dolcini]

On Tue, Nov 18, 2025 at 01:30:52PM +0100, Ernest Van Hoecke wrote:
> From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> In TEZI (Toradex Easy Installer), we use one U-Boot binary for both our
> NAND and eMMC Colibri iMX7 modules. Currently, CONFIG_PREBOOT sets the
> environment variable 'fdtfile' depending on which defconfig was used,
> adding the '-emmc' variant for the emmc defconfig. Since we always build
> the TEZI recovery U-Boot with the standard (non-emmc) defconfig, fdtfile
> has to be overwritten later or it will be wrong there.
> 
> By using '$variant', the fdtfile var is properly constructed at run time
> for both the NAND and eMMC variants, and we do not have to worry about
> setting fdtfile again when building the recovery TEZI U-Boot.
> 
> This also synchronizes these configs with how we handle the iMX6ULL.
> 
> Fixes: 327381e8b57c ("colibri_imx7: use preboot for fdtfile evaluation")
> Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Re: [PATCH v1] configs: colibri-imx7*: set 'fdtfile' generically in PREBOOT

[Francesco Dolcini]

On Tue, Nov 18, 2025 at 01:36:48PM +0100, Francesco Dolcini wrote:
> On Tue, Nov 18, 2025 at 01:30:52PM +0100, Ernest Van Hoecke wrote:
> > From: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> > 
> > In TEZI (Toradex Easy Installer), we use one U-Boot binary for both our
> > NAND and eMMC Colibri iMX7 modules. Currently, CONFIG_PREBOOT sets the
> > environment variable 'fdtfile' depending on which defconfig was used,
> > adding the '-emmc' variant for the emmc defconfig. Since we always build
> > the TEZI recovery U-Boot with the standard (non-emmc) defconfig, fdtfile
> > has to be overwritten later or it will be wrong there.
> > 
> > By using '$variant', the fdtfile var is properly constructed at run time
> > for both the NAND and eMMC variants, and we do not have to worry about
> > setting fdtfile again when building the recovery TEZI U-Boot.
> > 
> > This also synchronizes these configs with how we handle the iMX6ULL.
> > 
> > Fixes: 327381e8b57c ("colibri_imx7: use preboot for fdtfile evaluation")
> > Signed-off-by: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>
> 
> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

nack, I did a mistake.

There is an error in the patch, we need to keep the ${soc} variable to
differentiate between imx7d and imx7s

Francesco