All of lore.kernel.org
 help / color / mirror / Atom feed
From: cp0613@linux.alibaba.com
To: pjw@kernel.org
Cc: anup@brainfault.org, atish.patra@linux.dev,
	cp0613@linux.alibaba.com, guoren@kernel.org, haibo1.xu@intel.com,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions
Date: Tue, 18 Nov 2025 21:06:44 +0800	[thread overview]
Message-ID: <20251118130644.468-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org>

On Sun, 16 Nov 2025 10:22:34 -0700, pjw@kernel.org:

> > The file tools/arch/riscv/include/asm/csr.h borrows from
> > arch/riscv/include/asm/csr.h, and subsequent modifications
> > related to CSR should maintain consistency.
> 
> Thanks for the patch.  A few comments:
> 
> > Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests")
> > Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name")
> 
> It seems like this is pushing the definition of "fixes" here.  It looks 
> like the only thing wrong with those patches is that they didn't change 
> the files under tools/. right?  It would have been nice if they had 
> included the changes to files under tools/, but since the patches don't 
> introduce any bugs directly, I don't think we should include these Fixes: 
> lines here.
> 

Yes, that's true, thanks for reminding me.

> >
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> 
> Please, no blank line between the Fixes: headers and the Signed-off-by:.
> 
> I've removed the Fixes: lines and the superfluous blank line, and queued 
> this for v6.18-rc fixes.
> 

Thank you for your help.

> 
> - Paul

Thanks,
Pei

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: cp0613@linux.alibaba.com
To: pjw@kernel.org
Cc: anup@brainfault.org, atish.patra@linux.dev,
	cp0613@linux.alibaba.com, guoren@kernel.org, haibo1.xu@intel.com,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH] tools: riscv: Fixed misalignment of CSR related definitions
Date: Tue, 18 Nov 2025 21:06:44 +0800	[thread overview]
Message-ID: <20251118130644.468-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <421f4746-8d75-227b-6459-bbd82dfd6fa9@kernel.org>

On Sun, 16 Nov 2025 10:22:34 -0700, pjw@kernel.org:

> > The file tools/arch/riscv/include/asm/csr.h borrows from
> > arch/riscv/include/asm/csr.h, and subsequent modifications
> > related to CSR should maintain consistency.
> 
> Thanks for the patch.  A few comments:
> 
> > Fixes: 16b0bde9a37c ("RISC-V: KVM: Add perf sampling support for guests")
> > Fixes: d1927f64e0e1 ("RISC-V: Fix the typo in Scountovf CSR name")
> 
> It seems like this is pushing the definition of "fixes" here.  It looks 
> like the only thing wrong with those patches is that they didn't change 
> the files under tools/. right?  It would have been nice if they had 
> included the changes to files under tools/, but since the patches don't 
> introduce any bugs directly, I don't think we should include these Fixes: 
> lines here.
> 

Yes, that's true, thanks for reminding me.

> >
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> 
> Please, no blank line between the Fixes: headers and the Signed-off-by:.
> 
> I've removed the Fixes: lines and the superfluous blank line, and queued 
> this for v6.18-rc fixes.
> 

Thank you for your help.

> 
> - Paul

Thanks,
Pei

  reply	other threads:[~2025-11-18 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-14  7:12 [PATCH] tools: riscv: Fixed misalignment of CSR related definitions cp0613
2025-11-14  7:12 ` cp0613
2025-11-16 17:22 ` Paul Walmsley
2025-11-16 17:22   ` Paul Walmsley
2025-11-18 13:06   ` cp0613 [this message]
2025-11-18 13:06     ` cp0613
2025-11-17  8:10 ` patchwork-bot+linux-riscv
2025-11-17  8:10   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251118130644.468-1-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=anup@brainfault.org \
    --cc=atish.patra@linux.dev \
    --cc=guoren@kernel.org \
    --cc=haibo1.xu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=pjw@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.