From: Rob Herring <robh@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Andy Shevchenko" <andy@kernel.org>,
"Sean Anderson" <sean.anderson@linux.dev>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/6] spi: dt-bindings: Add spi-data-buses property
Date: Tue, 18 Nov 2025 09:57:17 -0600 [thread overview]
Message-ID: <20251118155717.GA3236324-robh@kernel.org> (raw)
In-Reply-To: <20251107-spi-add-multi-bus-support-v2-1-8a92693314d9@baylibre.com>
On Fri, Nov 07, 2025 at 02:52:47PM -0600, David Lechner wrote:
> Add a spi-data-buses property to the spi-peripheral-props binding to
> allow specifying the SPI data bus or buses that a peripheral is
> connected to in cases where the SPI controller has more than one
> physical SPI data bus.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
>
> v2 changes:
> * Renamed property from spi-buses to spi-data-buses to make it clear
> that we are only talking about the SDI/SDO lines and not the entire
> SPI bus (SCK, CS, etc).
> * Fixed prefix order in subject.
>
> This patch has been seen before in a different series from Sean [1].
>
> [1]: https://lore.kernel.org/linux-spi/20250616220054.3968946-2-sean.anderson@linux.dev/
>
> Changes:
> * Added maxItems. (8 is the most I've seen so far on an ADC)
> * Tweaked the description a bit.
> ---
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> index 8b6e8fc009dbdc80978f3afef84ddc688ade4348..6fe739eaf09876b9c5d8902f792ca02181d7266f 100644
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> @@ -89,6 +89,18 @@ properties:
> description:
> Delay, in microseconds, after a write transfer.
>
> + spi-data-buses:
I think spi-data-map would be better.
Or we could just reuse 'data-lanes' property. It seems like the same
problem of mapping peripheral lanes/lines to controller/host
lanes/lines.
> + description:
> + Array of data bus numbers that describes which SPI data buses of the
> + controller are connected to the peripheral. This only applies to
> + peripherals connected to specialized SPI controllers that have multiple
> + SPI data buses (a set of independent SDI/SDO lines each with its own
> + serializer) on a single controller.
Please make it clear what's the index and what's the value: "The index
corresponds to the peripheral data line and the value corresponds to the
controller data line."
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> + default: [0]
> +
> stacked-memories:
> description: Several SPI memories can be wired in stacked mode.
> This basically means that either a device features several chip
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-11-18 15:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 20:52 [PATCH v2 0/6] spi: add multi-bus support David Lechner
2025-11-07 20:52 ` [PATCH v2 1/6] spi: dt-bindings: Add spi-data-buses property David Lechner
2025-11-18 15:57 ` Rob Herring [this message]
2025-11-07 20:52 ` [PATCH v2 2/6] spi: Support multi-bus controllers David Lechner
2025-11-07 20:52 ` [PATCH v2 3/6] spi: add multi_bus_mode field to struct spi_transfer David Lechner
2025-11-07 20:52 ` [PATCH v2 4/6] spi: axi-spi-engine: support SPI_MULTI_BUS_MODE_STRIPE David Lechner
2025-11-11 15:12 ` Marcelo Schmitt
2025-11-12 16:59 ` David Lechner
2025-11-15 14:16 ` Marcelo Schmitt
2025-11-15 14:17 ` Marcelo Schmitt
2025-11-07 20:52 ` [PATCH v2 5/6] dt-bindings: iio: adc: adi,ad7380: add spi-buses property David Lechner
2025-11-18 15:59 ` Rob Herring
2025-11-18 17:46 ` David Lechner
2025-11-19 13:18 ` Rob Herring
2025-11-19 14:45 ` David Lechner
2025-12-04 14:28 ` Rob Herring
2025-12-04 16:01 ` David Lechner
2025-11-07 20:52 ` [PATCH v2 6/6] iio: adc: ad7380: Add support for multiple SPI buses David Lechner
2025-11-09 17:05 ` [PATCH v2 0/6] spi: add multi-bus support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118155717.GA3236324-robh@kernel.org \
--to=robh@kernel.org \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.