All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Hoan Tran <hoan@os.amperecomputing.com>,
	Andy Shevchenko <andy@kernel.org>,
	Daniel Palmer <daniel@thingy.jp>,
	Romain Perier <romain.perier@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	Srinivas Neeli <srinivas.neeli@amd.com>,
	Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH v4 05/15] gpio: pxa: Use modern PM macros
Date: Thu, 20 Nov 2025 00:33:17 +0800	[thread overview]
Message-ID: <20251119163327.16306-6-jszhang@kernel.org> (raw)
In-Reply-To: <20251119163327.16306-1-jszhang@kernel.org>

Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards.

This has the advantage of always compiling these functions in,
independently of any Kconfig option. Thanks to that, bugs and other
regressions are subsequently easier to catch.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-pxa.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index fa22f3faa163..17350fea2113 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -67,12 +67,10 @@ struct pxa_gpio_bank {
 	unsigned long	irq_edge_rise;
 	unsigned long	irq_edge_fall;
 
-#ifdef CONFIG_PM
 	unsigned long	saved_gplr;
 	unsigned long	saved_gpdr;
 	unsigned long	saved_grer;
 	unsigned long	saved_gfer;
-#endif
 };
 
 struct pxa_gpio_chip {
@@ -746,7 +744,6 @@ static int __init pxa_gpio_dt_init(void)
 }
 device_initcall(pxa_gpio_dt_init);
 
-#ifdef CONFIG_PM
 static int pxa_gpio_suspend(void)
 {
 	struct pxa_gpio_chip *pchip = pxa_gpio_chip;
@@ -787,14 +784,10 @@ static void pxa_gpio_resume(void)
 		writel_relaxed(c->saved_gpdr, c->regbase + GPDR_OFFSET);
 	}
 }
-#else
-#define pxa_gpio_suspend	NULL
-#define pxa_gpio_resume		NULL
-#endif
 
 static struct syscore_ops pxa_gpio_syscore_ops = {
-	.suspend	= pxa_gpio_suspend,
-	.resume		= pxa_gpio_resume,
+	.suspend	= pm_ptr(pxa_gpio_suspend),
+	.resume		= pm_ptr(pxa_gpio_resume),
 };
 
 static int __init pxa_gpio_sysinit(void)
-- 
2.51.0



  parent reply	other threads:[~2025-11-19 16:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 16:33 [PATCH v4 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-19 17:45   ` Andy Shevchenko
2025-11-20  0:28     ` Jisheng Zhang
2025-11-20  7:02       ` Andy Shevchenko
2025-11-19 16:33 ` [PATCH v4 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 04/15] gpio: pl061: " Jisheng Zhang
2025-11-19 16:33 ` Jisheng Zhang [this message]
2025-11-19 17:41   ` [PATCH v4 05/15] gpio: pxa: " Andy Shevchenko
2025-11-20  0:24     ` Jisheng Zhang
2025-11-20  7:01       ` Andy Shevchenko
2025-11-19 16:33 ` [PATCH v4 06/15] gpio: ml-ioh: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 08/15] gpio: msc313: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 09/15] gpio: omap: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 10/15] gpio: pch: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-19 17:19   ` Andy Shevchenko
2025-11-20  0:10     ` Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 13/15] gpio: xgene: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 16:52 ` [PATCH v4 00/15] gpio: " Bartosz Golaszewski
2025-11-19 17:47 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119163327.16306-6-jszhang@kernel.org \
    --to=jszhang@kernel.org \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=daniel@thingy.jp \
    --cc=florian.fainelli@broadcom.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hoan@os.amperecomputing.com \
    --cc=khilman@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=opendmb@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=romain.perier@gmail.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=srinivas.neeli@amd.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.