All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Hoan Tran <hoan@os.amperecomputing.com>,
	Andy Shevchenko <andy@kernel.org>,
	Daniel Palmer <daniel@thingy.jp>,
	Romain Perier <romain.perier@gmail.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
	Srinivas Neeli <srinivas.neeli@amd.com>,
	Michal Simek <michal.simek@amd.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: [PATCH v4 06/15] gpio: ml-ioh: Use modern PM macros
Date: Thu, 20 Nov 2025 00:33:18 +0800	[thread overview]
Message-ID: <20251119163327.16306-7-jszhang@kernel.org> (raw)
In-Reply-To: <20251119163327.16306-1-jszhang@kernel.org>

Use the modern PM macros for the suspend and resume functions to be
automatically dropped by the compiler when CONFIG_PM or
CONFIG_PM_SLEEP are disabled, without having to use __maybe_unused

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Andy Shevchenko <andy@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/gpio-ml-ioh.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index f6af81bf2b13..6576e5dcb0ee 100644
--- a/drivers/gpio/gpio-ml-ioh.c
+++ b/drivers/gpio/gpio-ml-ioh.c
@@ -160,7 +160,7 @@ static int ioh_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
 /*
  * Save register configuration and disable interrupts.
  */
-static void __maybe_unused ioh_gpio_save_reg_conf(struct ioh_gpio *chip)
+static void ioh_gpio_save_reg_conf(struct ioh_gpio *chip)
 {
 	int i;
 
@@ -186,7 +186,7 @@ static void __maybe_unused ioh_gpio_save_reg_conf(struct ioh_gpio *chip)
 /*
  * This function restores the register configuration of the GPIO device.
  */
-static void __maybe_unused ioh_gpio_restore_reg_conf(struct ioh_gpio *chip)
+static void ioh_gpio_restore_reg_conf(struct ioh_gpio *chip)
 {
 	int i;
 
@@ -479,7 +479,7 @@ static int ioh_gpio_probe(struct pci_dev *pdev,
 	return 0;
 }
 
-static int __maybe_unused ioh_gpio_suspend(struct device *dev)
+static int ioh_gpio_suspend(struct device *dev)
 {
 	struct ioh_gpio *chip = dev_get_drvdata(dev);
 	unsigned long flags;
@@ -491,7 +491,7 @@ static int __maybe_unused ioh_gpio_suspend(struct device *dev)
 	return 0;
 }
 
-static int __maybe_unused ioh_gpio_resume(struct device *dev)
+static int ioh_gpio_resume(struct device *dev)
 {
 	struct ioh_gpio *chip = dev_get_drvdata(dev);
 	unsigned long flags;
@@ -505,7 +505,7 @@ static int __maybe_unused ioh_gpio_resume(struct device *dev)
 	return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(ioh_gpio_pm_ops, ioh_gpio_suspend, ioh_gpio_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(ioh_gpio_pm_ops, ioh_gpio_suspend, ioh_gpio_resume);
 
 static const struct pci_device_id ioh_gpio_pcidev_id[] = {
 	{ PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x802E) },
@@ -518,7 +518,7 @@ static struct pci_driver ioh_gpio_driver = {
 	.id_table = ioh_gpio_pcidev_id,
 	.probe = ioh_gpio_probe,
 	.driver = {
-		.pm = &ioh_gpio_pm_ops,
+		.pm = pm_sleep_ptr(&ioh_gpio_pm_ops),
 	},
 };
 
-- 
2.51.0



  parent reply	other threads:[~2025-11-19 16:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-19 16:33 [PATCH v4 00/15] gpio: Use modern PM macros Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 01/15] gpio: dwapb: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 02/15] gpio: brcmstb: " Jisheng Zhang
2025-11-19 17:45   ` Andy Shevchenko
2025-11-20  0:28     ` Jisheng Zhang
2025-11-20  7:02       ` Andy Shevchenko
2025-11-19 16:33 ` [PATCH v4 03/15] gpio: htc-egpio: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 04/15] gpio: pl061: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 05/15] gpio: pxa: " Jisheng Zhang
2025-11-19 17:41   ` Andy Shevchenko
2025-11-20  0:24     ` Jisheng Zhang
2025-11-20  7:01       ` Andy Shevchenko
2025-11-19 16:33 ` Jisheng Zhang [this message]
2025-11-19 16:33 ` [PATCH v4 07/15] gpio: mlxbf2: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 08/15] gpio: msc313: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 09/15] gpio: omap: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 10/15] gpio: pch: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 11/15] gpio: tqmx86: " Jisheng Zhang
2025-11-19 17:19   ` Andy Shevchenko
2025-11-20  0:10     ` Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 12/15] gpio: uniphier: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 13/15] gpio: xgene: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 14/15] gpio: xilinx: " Jisheng Zhang
2025-11-19 16:33 ` [PATCH v4 15/15] gpio: zynq: " Jisheng Zhang
2025-11-19 16:52 ` [PATCH v4 00/15] gpio: " Bartosz Golaszewski
2025-11-19 17:47 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251119163327.16306-7-jszhang@kernel.org \
    --to=jszhang@kernel.org \
    --cc=andy@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=daniel@thingy.jp \
    --cc=florian.fainelli@broadcom.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hoan@os.amperecomputing.com \
    --cc=khilman@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=michal.simek@amd.com \
    --cc=opendmb@gmail.com \
    --cc=robert.jarzmik@free.fr \
    --cc=romain.perier@gmail.com \
    --cc=shubhrajyoti.datta@amd.com \
    --cc=srinivas.neeli@amd.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.