From: Christoph Hellwig <hch@lst.de>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, Biju Das <biju.das.jz@bp.renesas.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"urezki@gmail.com" <urezki@gmail.com>
Subject: Re: [PATCH v3 0/4] make vmalloc gfp flags usage more apparent
Date: Fri, 21 Nov 2025 08:29:45 +0100 [thread overview]
Message-ID: <20251121072945.GA30438@lst.de> (raw)
In-Reply-To: <aR4SmclGax8584IJ@fedora>
On Wed, Nov 19, 2025 at 10:55:21AM -0800, Vishal Moola (Oracle) wrote:
> > Unexpected gfp: 0x1000000 (__GFP_NOLOCKDEP). Fixing up to gfp: 0x2dc0 (GFP_KERNEL|__GFP_ZERO|__GFP_NOWARN). Fix your code!
> >
> > I suspect __GFP_NOLOCKDEP should also be permitted by vmalloc.
>
> As far as I can tell, theres only 1 caller of this.
> Christoph started using vmalloc for this xfs call in commit
> e2874632a621 ("xfs: use vmalloc instead of vm_map_area for buffer backing memory").
>
> Looks like xfs uses the flag to prevent false positives. Do
> we want to continue this? If so, I'll send a patch adding the flag to
> the whitelist.
I'm not a fan of __GFP_NOLOCKDEP, but it is a valid hint for the
allocator, so it should be supported.
next prev parent reply other threads:[~2025-11-21 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:14 [PATCH v3 0/4] make vmalloc gfp flags usage more apparent Biju Das
2025-11-18 17:07 ` Vishal Moola (Oracle)
2025-11-18 19:57 ` Matthew Wilcox
2025-11-19 18:55 ` Vishal Moola (Oracle)
2025-11-21 7:29 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-11-17 17:35 Vishal Moola (Oracle)
2025-11-20 1:03 ` SeongJae Park
2025-11-20 18:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121072945.GA30438@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=bpf@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.