From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org
Cc: Biju Das <biju.das.jz@bp.renesas.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"urezki@gmail.com" <urezki@gmail.com>
Subject: Re: [PATCH v3 0/4] make vmalloc gfp flags usage more apparent
Date: Wed, 19 Nov 2025 10:55:21 -0800 [thread overview]
Message-ID: <aR4SmclGax8584IJ@fedora> (raw)
In-Reply-To: <aRzPqYfXc6mtR1U9@casper.infradead.org>
On Tue, Nov 18, 2025 at 07:57:29PM +0000, Matthew Wilcox wrote:
> On Tue, Nov 18, 2025 at 09:07:56AM -0800, Vishal Moola (Oracle) wrote:
> > On Tue, Nov 18, 2025 at 04:14:01PM +0000, Biju Das wrote:
> > > Hi All,
> > >
> > > I get below warning with today's next. Can you please suggest how to fix this warning?
> >
> > Thanks Biju. This has been fixed and will be in whenever Andrews tree
> > gets merged again.
>
> I see:
>
> Unexpected gfp: 0x1000000 (__GFP_NOLOCKDEP). Fixing up to gfp: 0x2dc0 (GFP_KERNEL|__GFP_ZERO|__GFP_NOWARN). Fix your code!
>
> I suspect __GFP_NOLOCKDEP should also be permitted by vmalloc.
As far as I can tell, theres only 1 caller of this.
Christoph started using vmalloc for this xfs call in commit
e2874632a621 ("xfs: use vmalloc instead of vm_map_area for buffer backing memory").
Looks like xfs uses the flag to prevent false positives. Do
we want to continue this? If so, I'll send a patch adding the flag to
the whitelist.
next prev parent reply other threads:[~2025-11-19 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:14 [PATCH v3 0/4] make vmalloc gfp flags usage more apparent Biju Das
2025-11-18 17:07 ` Vishal Moola (Oracle)
2025-11-18 19:57 ` Matthew Wilcox
2025-11-19 18:55 ` Vishal Moola (Oracle) [this message]
2025-11-21 7:29 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2025-11-17 17:35 Vishal Moola (Oracle)
2025-11-20 1:03 ` SeongJae Park
2025-11-20 18:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR4SmclGax8584IJ@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=bpf@vger.kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.