From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] kbuild: Support directory targets for building DTBs
Date: Fri, 21 Nov 2025 15:20:29 -0700 [thread overview]
Message-ID: <20251121222029.GA1674270@ax162> (raw)
In-Reply-To: <aSDAqhUb8_76IP0Y@derry.ads.avm.de>
On Fri, Nov 21, 2025 at 08:42:34PM +0100, Nicolas Schier wrote:
> Using '$(filter )' instead of '$(findstring )' reduces the risk of false
> positives, e.g.:
>
> dtb-targets := %/dts %.dtb %.dtbo dtbs dtbs_check
> ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)
Oh yeah, that would seem to clear up my concerns.
> With (something like) that:
> Tested-by: Nicolas Schier <nsc@kernel.org>
> Acked-by: Nicolas Schier <nsc@kernel.org>
Agreed.
Acked-by: Nathan Chancellor <nathan@kernel.org>
> But [1] seems to break this patch.
>
> [1]: https://lore.kernel.org/linux-kbuild/20251120140645.478623-1-thomas.de_schampheleire@nokia.com
Yeah, that will need to be coordinated, I cc'd Rob on that change for
him to take a look as well.
Cheers,
Nathan
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nsc@kernel.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] kbuild: Support directory targets for building DTBs
Date: Fri, 21 Nov 2025 15:20:29 -0700 [thread overview]
Message-ID: <20251121222029.GA1674270@ax162> (raw)
In-Reply-To: <aSDAqhUb8_76IP0Y@derry.ads.avm.de>
On Fri, Nov 21, 2025 at 08:42:34PM +0100, Nicolas Schier wrote:
> Using '$(filter )' instead of '$(findstring )' reduces the risk of false
> positives, e.g.:
>
> dtb-targets := %/dts %.dtb %.dtbo dtbs dtbs_check
> ifneq ($(findstring /dts/,$(MAKECMDGOALS))$(filter $(dtb-targets),$(MAKECMDGOALS)),)
Oh yeah, that would seem to clear up my concerns.
> With (something like) that:
> Tested-by: Nicolas Schier <nsc@kernel.org>
> Acked-by: Nicolas Schier <nsc@kernel.org>
Agreed.
Acked-by: Nathan Chancellor <nathan@kernel.org>
> But [1] seems to break this patch.
>
> [1]: https://lore.kernel.org/linux-kbuild/20251120140645.478623-1-thomas.de_schampheleire@nokia.com
Yeah, that will need to be coordinated, I cc'd Rob on that change for
him to take a look as well.
Cheers,
Nathan
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-11-21 22:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 20:48 [PATCH v2] kbuild: Support directory targets for building DTBs Rob Herring (Arm)
2025-11-20 20:48 ` Rob Herring (Arm)
2025-11-21 6:30 ` Nathan Chancellor
2025-11-21 6:30 ` Nathan Chancellor
2025-11-21 19:42 ` Nicolas Schier
2025-11-21 19:42 ` Nicolas Schier
2025-11-21 22:20 ` Nathan Chancellor [this message]
2025-11-21 22:20 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251121222029.GA1674270@ax162 \
--to=nathan@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=nsc@kernel.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.