Re: [PATCH v1] phy: fsl-imx8mq-usb: fix typec orientation switch when built as module

From: Francesco Dolcini <francesco@dolcini.it>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Franz Schnyder <fra.schnyder@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Franz Schnyder <franz.schnyder@toradex.com>,
	linux-phy@lists.infradead.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v1] phy: fsl-imx8mq-usb: fix typec orientation switch when built as module
Date: Tue, 25 Nov 2025 08:20:11 +0100	[thread overview]
Message-ID: <20251125072011.GA5375@francesco-nb> (raw)
In-Reply-To: <w2dpsbfspr4od2j5seidi3tcpo3r2revhahhxiuacqehkqy3nn@2zjb3xvso45d>

On Tue, Nov 25, 2025 at 03:04:43PM +0800, Xu Yang wrote:
> On Mon, Nov 24, 2025 at 10:50:04AM +0100, Franz Schnyder wrote:
> > From: Franz Schnyder <franz.schnyder@toradex.com>
> > 
> > Currently, the PHY only registers the typec orientation switch when it
> > is built in. If the typec driver is built as a module, the switch
> > registration is skipped due to the preprocessor condition, causing
> > orientation detection to fail.
> > 
> > This patch replaces the preprocessor condition so that the orientation
> > switch is correctly registered for both built-in and module builds.
> > 
> > Fixes: b58f0f86fd61 ("phy: fsl-imx8mq-usb: add tca function driver for imx95")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Franz Schnyder <franz.schnyder@toradex.com>
> > ---
> >  drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > index b94f242420fc..d498a6b7234b 100644
> > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> > @@ -124,7 +124,7 @@ struct imx8mq_usb_phy {
> >  static void tca_blk_orientation_set(struct tca_blk *tca,
> >  				enum typec_orientation orientation);
> >  
> > -#ifdef CONFIG_TYPEC
> > +#if IS_ENABLED(CONFIG_TYPEC)
> 
> With below commit:
> 
> 45fe729be9a6 usb: typec: Stub out typec_switch APIs when CONFIG_TYPEC=n
> 
> I think this #if/else/endif condition can be removed.

This patch should go to stable, and that commit is not present in any
such previous kernel.

Should we have 2 patches or "force" 45fe729be9a6 to be also backported?

What's the general advise in these situations?

Francesco