From: Christoph Hellwig <hch@lst.de>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Keith Busch <kbusch@kernel.org>, Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk, hch@lst.de,
ebiggers@kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCHv6] blk-integrity: support arbitrary buffer alignment
Date: Tue, 25 Nov 2025 12:31:44 +0100 [thread overview]
Message-ID: <20251125113144.GA22938@lst.de> (raw)
In-Reply-To: <CADUfDZogsF53MENLLyd0iCGKUoSqap3bEfSbt72KPifO4tvzfA@mail.gmail.com>
On Mon, Nov 24, 2025 at 07:41:16PM -0800, Caleb Sander Mateos wrote:
> > Compare kmap_local_page() with kmap_local_folio(). They both resolve to
> > the same lower level mapping function, and folios have no problem
> > spanning pages.
>
> Documentation/mm/highmem.rst seems to suggest that kmap_local_folio()
> only maps the page that contains the specified offset, not the whole
> folio:
Yes. Additionally multi-page bvecs aren't folios, they just are
physically contiguous ranges. So I don't think we could even use any
folio helpers if they worked, as a single range might consist of multiple
folios.
(Sorry for not spotting this earlier)
next prev parent reply other threads:[~2025-11-25 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:17 [PATCHv6] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-24 16:31 ` Martin K. Petersen
2025-11-24 17:57 ` Keith Busch
2025-11-24 20:49 ` Martin K. Petersen
2025-11-24 16:58 ` Christoph Hellwig
2025-11-24 21:34 ` Caleb Sander Mateos
2025-11-24 22:56 ` Keith Busch
2025-11-25 3:41 ` Caleb Sander Mateos
2025-11-25 11:31 ` Christoph Hellwig [this message]
2025-11-25 14:24 ` Keith Busch
2025-11-25 16:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125113144.GA22938@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=ebiggers@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.