From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Caleb Sander Mateos <csander@purestorage.com>,
Keith Busch <kbusch@meta.com>,
linux-block@vger.kernel.org, axboe@kernel.dk,
ebiggers@kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCHv6] blk-integrity: support arbitrary buffer alignment
Date: Tue, 25 Nov 2025 17:46:04 +0100 [thread overview]
Message-ID: <20251125164604.GA29226@lst.de> (raw)
In-Reply-To: <aSW8G5C--oIzmfJa@kbusch-mbp>
On Tue, Nov 25, 2025 at 07:24:27AM -0700, Keith Busch wrote:
> So the solution is to replace mp_bvec_iter_bvec() with bvec_iter_bvec()
> to ensure we don't cross pages? It's a little less efficient, but that's
> not a big deal.
Yes. At least for CONFIG_HIGHMEM. Note that in many places I actually
found that open coding these macros leads to nicer code, and with that
CONFIG_HIGHMEM ifdef that would probably also be the case.
> I assumed mapping physically congiguous memory was contiguous in kernel
> address space too,
It is.
> and that seems to work out in testing, but I don't
> have CONFIG_HIGHMEM enable where that might matter.
I keep an x86_32 VM around for that, but I usually only fire it up when
it's too late..
prev parent reply other threads:[~2025-11-25 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:17 [PATCHv6] blk-integrity: support arbitrary buffer alignment Keith Busch
2025-11-24 16:31 ` Martin K. Petersen
2025-11-24 17:57 ` Keith Busch
2025-11-24 20:49 ` Martin K. Petersen
2025-11-24 16:58 ` Christoph Hellwig
2025-11-24 21:34 ` Caleb Sander Mateos
2025-11-24 22:56 ` Keith Busch
2025-11-25 3:41 ` Caleb Sander Mateos
2025-11-25 11:31 ` Christoph Hellwig
2025-11-25 14:24 ` Keith Busch
2025-11-25 16:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125164604.GA29226@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=ebiggers@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.