[PATCH] script/execute: Add NULL check for grub_calloc in gettext_append

[PATCH] script/execute: Add NULL check for grub_calloc in gettext_append

[Sridhar Markonda]

Add a NULL check after grub_calloc in gettext_append to handle allocation errors.
This prevents using a NULL pointer and stops crashes during string translation.

Signed-off-by: Sridhar Markonda <sridharm@linux.ibm.com>
Signed-off-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>
---
 grub-core/script/execute.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/grub-core/script/execute.c b/grub-core/script/execute.c
index 62afcdc99..369d985ee 100644
--- a/grub-core/script/execute.c
+++ b/grub-core/script/execute.c
@@ -562,6 +562,8 @@ gettext_append (struct grub_script_argv *result, const char *orig_str)
     if (*iptr == '$')
       dollar_cnt++;
   ctx.allowed_strings = grub_calloc (dollar_cnt, sizeof (ctx.allowed_strings[0]));
+  if (ctx.allowed_strings == NULL)
+    goto fail;
 
   if (parse_string (orig_str, gettext_save_allow, &ctx, 0))
     goto fail;
-- 
2.47.3


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH] script/execute: Add NULL check for grub_calloc in gettext_append

[Daniel Kiper]

On Tue, Dec 02, 2025 at 12:38:45PM +0530, Sridhar Markonda wrote:
> Add a NULL check after grub_calloc in gettext_append to handle allocation errors.
> This prevents using a NULL pointer and stops crashes during string translation.
>
> Signed-off-by: Sridhar Markonda <sridharm@linux.ibm.com>
> Signed-off-by: Sudhakar Kuppusamy <sudhakar@linux.ibm.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel