* [PATCH] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata
@ 2025-12-02 11:47 Thorsten Blum
2025-12-03 1:38 ` Baolin Wang
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-12-02 11:47 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Orson Zhai, Baolin Wang, Chunyan Zhang, Freeman Liu
Cc: Thorsten Blum, stable, linux-pm, linux-kernel
The temperature was never clamped to SPRD_THM_TEMP_LOW or
SPRD_THM_TEMP_HIGH because the return value of clamp() was not used. Fix
this by assigning the clamped value to 'temp'.
Casting SPRD_THM_TEMP_LOW and SPRD_THM_TEMP_HIGH to int is also
redundant and can be removed.
Cc: stable@vger.kernel.org
Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/thermal/sprd_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
index f7fa83b2428e..44fa45f74da7 100644
--- a/drivers/thermal/sprd_thermal.c
+++ b/drivers/thermal/sprd_thermal.c
@@ -192,7 +192,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
{
u32 val;
- clamp(temp, (int)SPRD_THM_TEMP_LOW, (int)SPRD_THM_TEMP_HIGH);
+ temp = clamp(temp, SPRD_THM_TEMP_LOW, SPRD_THM_TEMP_HIGH);
/*
* According to the thermal datasheet, the formula of converting
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata
2025-12-02 11:47 [PATCH] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata Thorsten Blum
@ 2025-12-03 1:38 ` Baolin Wang
0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2025-12-03 1:38 UTC (permalink / raw)
To: Thorsten Blum, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Orson Zhai, Chunyan Zhang, Freeman Liu
Cc: stable, linux-pm, linux-kernel
On 2025/12/2 19:47, Thorsten Blum wrote:
> The temperature was never clamped to SPRD_THM_TEMP_LOW or
> SPRD_THM_TEMP_HIGH because the return value of clamp() was not used. Fix
> this by assigning the clamped value to 'temp'.
>
> Casting SPRD_THM_TEMP_LOW and SPRD_THM_TEMP_HIGH to int is also
> redundant and can be removed.
>
> Cc: stable@vger.kernel.org
> Fixes: 554fdbaf19b1 ("thermal: sprd: Add Spreadtrum thermal driver support")
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/thermal/sprd_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index f7fa83b2428e..44fa45f74da7 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -192,7 +192,7 @@ static int sprd_thm_temp_to_rawdata(int temp, struct sprd_thermal_sensor *sen)
> {
> u32 val;
>
> - clamp(temp, (int)SPRD_THM_TEMP_LOW, (int)SPRD_THM_TEMP_HIGH);
> + temp = clamp(temp, SPRD_THM_TEMP_LOW, SPRD_THM_TEMP_HIGH);
>
> /*
> * According to the thermal datasheet, the formula of converting
Good catch. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-03 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-02 11:47 [PATCH] thermal: sprd: Fix temperature clamping in sprd_thm_temp_to_rawdata Thorsten Blum
2025-12-03 1:38 ` Baolin Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.