Re: [PATCH 4/4] i3c: drop i3c_priv_xfer and i3c_device_do_priv_xfers()

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	Jeremy Kerr <jk@codeconstruct.com.au>,
	Matt Johnston <matt@codeconstruct.com.au>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-i3c@lists.infradead.org
Subject: Re: [PATCH 4/4] i3c: drop i3c_priv_xfer and i3c_device_do_priv_xfers()
Date: Wed, 3 Dec 2025 00:15:26 +0100	[thread overview]
Message-ID: <2025120223152613f1586a@mail.local> (raw)
In-Reply-To: <20251028-lm75-v1-4-9bf88989c49c@nxp.com>

Hello Frank,

You'll have to rebase this patch.

On 28/10/2025 10:57:55-0400, Frank Li wrote:
> Drop i3c_priv_xfer and i3c_device_do_priv_xfers() after all driver switch
> to use new API.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> This patch need be applied after all other patches applied.
> ---
>  include/linux/i3c/device.h | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> index ae0662d9d77eb3fa0c976de1803e9c2ff9547451..47e6c95d87f9494d48c5b0463544916f26923501 100644
> --- a/include/linux/i3c/device.h
> +++ b/include/linux/i3c/device.h
> @@ -25,7 +25,7 @@
>   * @I3C_ERROR_M2: M2 error
>   *
>   * These are the standard error codes as defined by the I3C specification.
> - * When -EIO is returned by the i3c_device_do_priv_xfers() or
> + * When -EIO is returned by the i3c_device_do_i3c_xfers() or
>   * i3c_device_send_hdr_cmds() one can check the error code in
>   * &struct_i3c_xfer.err or &struct i3c_hdr_cmd.err to get a better idea of
>   * what went wrong.
> @@ -79,9 +79,6 @@ struct i3c_xfer {
>  	enum i3c_error_code err;
>  };
>  
> -/* keep back compatible */
> -#define i3c_priv_xfer i3c_xfer
> -
>  /**
>   * enum i3c_dcr - I3C DCR values
>   * @I3C_DCR_GENERIC_DEVICE: generic I3C device
> @@ -311,13 +308,6 @@ static __always_inline void i3c_i2c_driver_unregister(struct i3c_driver *i3cdrv,
>  int i3c_device_do_xfers(struct i3c_device *dev, struct i3c_xfer *xfers,
>  			int nxfers, enum i3c_xfer_mode mode);
>  
> -static inline int i3c_device_do_priv_xfers(struct i3c_device *dev,
> -					   struct i3c_xfer *xfers,
> -					   int nxfers)
> -{
> -	return i3c_device_do_xfers(dev, xfers, nxfers, I3C_SDR);
> -}
> -
>  int i3c_device_do_setdasa(struct i3c_device *dev);
>  
>  void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_info *info);
> 
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com