* [PATCH] drm/panthor: Remove redundant call to disable the MCU
@ 2025-12-03 9:19 Akash Goel
2025-12-03 10:53 ` Boris Brezillon
2025-12-03 13:27 ` Liviu Dudau
0 siblings, 2 replies; 3+ messages in thread
From: Akash Goel @ 2025-12-03 9:19 UTC (permalink / raw)
To: boris.brezillon, liviu.dudau, steven.price
Cc: dri-devel, karunika.choo, linux-kernel, maarten.lankhorst,
mripard, tzimmermann, airlied, daniel, nd, Akash Goel
This commit removes the redundant call to disable the MCU firmware
in the suspend path.
Fixes: 514072549865 ("drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs")
Signed-off-by: Akash Goel <akash.goel@arm.com>
---
drivers/gpu/drm/panthor/panthor_fw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
index 1a5e3c1a27fb..94a3cd6dfa6d 100644
--- a/drivers/gpu/drm/panthor/panthor_fw.c
+++ b/drivers/gpu/drm/panthor/panthor_fw.c
@@ -1187,7 +1187,6 @@ void panthor_fw_pre_reset(struct panthor_device *ptdev, bool on_hang)
else
ptdev->reset.fast = true;
}
- panthor_fw_stop(ptdev);
panthor_job_irq_suspend(&ptdev->fw->irq);
panthor_fw_stop(ptdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panthor: Remove redundant call to disable the MCU
2025-12-03 9:19 [PATCH] drm/panthor: Remove redundant call to disable the MCU Akash Goel
@ 2025-12-03 10:53 ` Boris Brezillon
2025-12-03 13:27 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2025-12-03 10:53 UTC (permalink / raw)
To: Akash Goel
Cc: liviu.dudau, steven.price, dri-devel, karunika.choo, linux-kernel,
maarten.lankhorst, mripard, tzimmermann, airlied, daniel, nd
On Wed, 3 Dec 2025 09:19:11 +0000
Akash Goel <akash.goel@arm.com> wrote:
> This commit removes the redundant call to disable the MCU firmware
> in the suspend path.
>
> Fixes: 514072549865 ("drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs")
> Signed-off-by: Akash Goel <akash.goel@arm.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 1a5e3c1a27fb..94a3cd6dfa6d 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -1187,7 +1187,6 @@ void panthor_fw_pre_reset(struct panthor_device *ptdev, bool on_hang)
> else
> ptdev->reset.fast = true;
> }
> - panthor_fw_stop(ptdev);
>
> panthor_job_irq_suspend(&ptdev->fw->irq);
> panthor_fw_stop(ptdev);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/panthor: Remove redundant call to disable the MCU
2025-12-03 9:19 [PATCH] drm/panthor: Remove redundant call to disable the MCU Akash Goel
2025-12-03 10:53 ` Boris Brezillon
@ 2025-12-03 13:27 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2025-12-03 13:27 UTC (permalink / raw)
To: Akash Goel
Cc: boris.brezillon, steven.price, dri-devel, karunika.choo,
linux-kernel, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, nd
On Wed, Dec 03, 2025 at 09:19:11AM +0000, Akash Goel wrote:
> This commit removes the redundant call to disable the MCU firmware
> in the suspend path.
>
> Fixes: 514072549865 ("drm/panthor: Support GLB_REQ.STATE field for Mali-G1 GPUs")
> Signed-off-by: Akash Goel <akash.goel@arm.com>
Pushed to drm-misc-next.
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index 1a5e3c1a27fb..94a3cd6dfa6d 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -1187,7 +1187,6 @@ void panthor_fw_pre_reset(struct panthor_device *ptdev, bool on_hang)
> else
> ptdev->reset.fast = true;
> }
> - panthor_fw_stop(ptdev);
>
> panthor_job_irq_suspend(&ptdev->fw->irq);
> panthor_fw_stop(ptdev);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-03 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-03 9:19 [PATCH] drm/panthor: Remove redundant call to disable the MCU Akash Goel
2025-12-03 10:53 ` Boris Brezillon
2025-12-03 13:27 ` Liviu Dudau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.