* [PATCH] drm/panel: visionox-rm69299: add backlight dependency
@ 2025-12-04 9:47 Arnd Bergmann
2025-12-04 10:23 ` Guido Günther
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-12-04 9:47 UTC (permalink / raw)
To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter,
Guido Günther, Dmitry Baryshkov
Cc: Arnd Bergmann, Jessica Zhang, Svyatoslav Ryhel, David Heidelberg,
Linus Walleij, Kaustabh Chakraborty, Maxim Schwalm,
AngeloGioacchino Del Regno, Colin Ian King, dri-devel,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The recently added backlight support breaks when CONFIG_BACKLIGHT_CLASS_DEVICE
is turned off:
arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-rm69299.o: in function `visionox_rm69299_probe':
panel-visionox-rm69299.c:(.text.visionox_rm69299_probe+0x92): undefined reference to `devm_backlight_device_register'
arm-linux-gnueabi-ld: (devm_backlight_device_register): Unknown destination type (ARM/Thumb) in drivers/gpu/drm/panel/panel-visionox-rm69299.o
Add the appropriate Kconfig dependency.
Fixes: 7911d8cab554 ("drm/panel: visionox-rm69299: Add backlight support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 76f6af819037..2923148dcf07 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -1163,6 +1163,7 @@ config DRM_PANEL_VISIONOX_R66451
config DRM_PANEL_VISIONOX_RM69299
tristate "Visionox RM69299"
+ depends on BACKLIGHT_CLASS_DEVICE
depends on OF
depends on DRM_MIPI_DSI
help
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/panel: visionox-rm69299: add backlight dependency
2025-12-04 9:47 [PATCH] drm/panel: visionox-rm69299: add backlight dependency Arnd Bergmann
@ 2025-12-04 10:23 ` Guido Günther
0 siblings, 0 replies; 2+ messages in thread
From: Guido Günther @ 2025-12-04 10:23 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Dmitry Baryshkov,
Arnd Bergmann, Jessica Zhang, Svyatoslav Ryhel, David Heidelberg,
Linus Walleij, Kaustabh Chakraborty, Maxim Schwalm,
AngeloGioacchino Del Regno, Colin Ian King, dri-devel,
linux-kernel
Hi,
On Thu, Dec 04, 2025 at 10:47:26AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The recently added backlight support breaks when CONFIG_BACKLIGHT_CLASS_DEVICE
> is turned off:
>
> arm-linux-gnueabi-ld: drivers/gpu/drm/panel/panel-visionox-rm69299.o: in function `visionox_rm69299_probe':
> panel-visionox-rm69299.c:(.text.visionox_rm69299_probe+0x92): undefined reference to `devm_backlight_device_register'
> arm-linux-gnueabi-ld: (devm_backlight_device_register): Unknown destination type (ARM/Thumb) in drivers/gpu/drm/panel/panel-visionox-rm69299.o
>
> Add the appropriate Kconfig dependency.
>
> Fixes: 7911d8cab554 ("drm/panel: visionox-rm69299: Add backlight support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for looking at this. This is a duplicate of
https://lore.kernel.org/phone-devel/20251017-visionox-rm69299-bl-v2-1-9dfa06606754@sigxcpu.org/
though, idk why it didn't get applied.
Cheers,
-- Guido
> ---
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 76f6af819037..2923148dcf07 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -1163,6 +1163,7 @@ config DRM_PANEL_VISIONOX_R66451
>
> config DRM_PANEL_VISIONOX_RM69299
> tristate "Visionox RM69299"
> + depends on BACKLIGHT_CLASS_DEVICE
> depends on OF
> depends on DRM_MIPI_DSI
> help
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-04 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 9:47 [PATCH] drm/panel: visionox-rm69299: add backlight dependency Arnd Bergmann
2025-12-04 10:23 ` Guido Günther
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.