From: Nathan Chancellor <nathan@kernel.org>
To: xur@google.com
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alice Ryhl <aliceryhl@google.com>,
Sami Tolvanen <samitolvanen@google.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
Rafael Aquini <aquini@redhat.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Stafford Horne <shorne@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Piotr Gorski <piotrgorski@cachyos.org>,
Teresa Johnson <tejohnson@google.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v5 0/2] kbuild: distributed build support for Clang ThinLTO
Date: Thu, 4 Dec 2025 10:49:54 -0700 [thread overview]
Message-ID: <20251204174954.GA1177092@ax162> (raw)
In-Reply-To: <20251028182822.3210436-1-xur@google.com>
Hi Rong,
On Tue, Oct 28, 2025 at 06:28:20PM +0000, xur@google.com wrote:
First of all, my apologies for taking so long to get to testing and
reviewing this patchset.
> Rong Xu (2):
> kbuild: move vmlinux.a build rule to scripts/Makefile.vmlinux_a
> kbuild: distributed build support for Clang ThinLTO
>
> .gitignore | 2 +
> Makefile | 25 +++++-------
> arch/Kconfig | 19 +++++++++
> scripts/Makefile.lib | 7 ++++
> scripts/Makefile.thinlto | 40 ++++++++++++++++++
> scripts/Makefile.vmlinux_a | 83 ++++++++++++++++++++++++++++++++++++++
> scripts/mod/modpost.c | 15 +++++--
> 7 files changed, 174 insertions(+), 17 deletions(-)
> create mode 100644 scripts/Makefile.thinlto
> create mode 100644 scripts/Makefile.vmlinux_a
Overall, this seems reasonable from a high level perspective. I have
been testing it with my arm64 and x86_64 distribution configurations for
the past couple of days and I have not noticed any issues.
Did you take a look at the robot report from patch 2?
https://lore.kernel.org/202511052257.Bb85ptQG-lkp@intel.com/
It seems like it could be caused by different optimizations?
I plan to take a more in-depth look at the implementation after I am
back home from Plumbers in a couple of weeks (just to make sure I
understand it from a maintainer's perspective). Based on that, I will
either apply it to kbuild-next for 6.20/7.0 or ask for further
interations, while still aiming to get it into that release.
Cheers,
Natha
next prev parent reply other threads:[~2025-12-04 17:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 18:28 [PATCH v5 0/2] kbuild: distributed build support for Clang ThinLTO xur
2025-10-28 18:28 ` [PATCH v5 1/2] kbuild: move vmlinux.a build rule to scripts/Makefile.vmlinux_a xur
2026-03-16 13:33 ` Nicolas Schier
2026-03-16 13:59 ` Miguel Ojeda
2026-03-16 17:27 ` Rong Xu
2026-03-16 17:52 ` Nicolas Schier
2026-03-16 17:59 ` Nathan Chancellor
2026-03-16 18:16 ` Rong Xu
2026-03-16 20:43 ` Nathan Chancellor
2026-03-16 20:53 ` Rong Xu
2026-03-16 21:31 ` Rong Xu
2025-10-28 18:28 ` [PATCH v5 2/2] kbuild: distributed build support for Clang ThinLTO xur
2025-11-05 14:47 ` kernel test robot
2025-10-28 19:22 ` [PATCH v5 0/2] " Piotr Gorski
2025-12-04 17:49 ` Nathan Chancellor [this message]
2025-12-04 18:36 ` Rong Xu
2026-03-12 8:25 ` Nathan Chancellor
2026-03-12 11:45 ` Nicolas Schier
2026-03-12 17:50 ` Rong Xu
2026-03-13 14:50 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251204174954.GA1177092@ax162 \
--to=nathan@kernel.org \
--cc=aliceryhl@google.com \
--cc=aquini@redhat.com \
--cc=christophe.leroy@csgroup.eu \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=mpe@ellerman.id.au \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
--cc=ojeda@kernel.org \
--cc=piotrgorski@cachyos.org \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=shorne@gmail.com \
--cc=tejohnson@google.com \
--cc=tglx@linutronix.de \
--cc=xur@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.