* [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around
@ 2025-12-04 22:55 Ian Rogers
2025-12-04 22:55 ` [PATCH v2 2/2] perf tests top: Make the test exclusive Ian Rogers
2025-12-24 19:38 ` [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Namhyung Kim
0 siblings, 2 replies; 3+ messages in thread
From: Ian Rogers @ 2025-12-04 22:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, linux-kernel, linux-perf-users
Ensure the perf.data output when checking permissions is written to
/dev/null so that it isn't left in the directory the test is run.
Fixes: b58261584d2f ("perf test kvm: Add some basic perf kvm test coverage")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/kvm.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/kvm.sh b/tools/perf/tests/shell/kvm.sh
index 2fafde1a29cc..2a399b83fe80 100755
--- a/tools/perf/tests/shell/kvm.sh
+++ b/tools/perf/tests/shell/kvm.sh
@@ -118,7 +118,7 @@ setup_qemu() {
skip "/dev/kvm not accessible"
fi
- if ! perf kvm stat record -a sleep 0.01 >/dev/null 2>&1; then
+ if ! perf kvm stat record -o /dev/null -a sleep 0.01 >/dev/null 2>&1; then
skip "No permission to record kvm events"
fi
--
2.52.0.223.gf5cc29aaa4-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] perf tests top: Make the test exclusive
2025-12-04 22:55 [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Ian Rogers
@ 2025-12-04 22:55 ` Ian Rogers
2025-12-24 19:38 ` [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Ian Rogers @ 2025-12-04 22:55 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Namhyung Kim, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, linux-kernel, linux-perf-users
With sufficient tests running the load causes the top test fails with:
```
123: perf top tests : FAILED!
--- start ---
test child forked, pid 629856
Basic perf top test
Basic perf top test [Failed: no sample percentage found]
---- end(-1) ----
```
Mark the test exclusive to avoid flakes.
Fixes: 75e961730b9e ("perf tests top: Add basic perf top coverage test")
Signed-off-by: Ian Rogers <irogers@google.com>
---
v2; Tweak commit message log lines starting "---".
---
tools/perf/tests/shell/top.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/top.sh b/tools/perf/tests/shell/top.sh
index 768ebcf7a89c..ad7fccd09025 100755
--- a/tools/perf/tests/shell/top.sh
+++ b/tools/perf/tests/shell/top.sh
@@ -1,5 +1,5 @@
#!/bin/bash
-# perf top tests
+# perf top tests (exclusive)
# SPDX-License-Identifier: GPL-2.0
set -e
--
2.52.0.223.gf5cc29aaa4-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around
2025-12-04 22:55 [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Ian Rogers
2025-12-04 22:55 ` [PATCH v2 2/2] perf tests top: Make the test exclusive Ian Rogers
@ 2025-12-24 19:38 ` Namhyung Kim
1 sibling, 0 replies; 3+ messages in thread
From: Namhyung Kim @ 2025-12-24 19:38 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Alexander Shishkin, Jiri Olsa, Adrian Hunter, linux-kernel,
linux-perf-users, Ian Rogers
On Thu, 04 Dec 2025 14:55:21 -0800, Ian Rogers wrote:
> Ensure the perf.data output when checking permissions is written to
> /dev/null so that it isn't left in the directory the test is run.
>
>
Applied to perf-tools, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-24 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-04 22:55 [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Ian Rogers
2025-12-04 22:55 ` [PATCH v2 2/2] perf tests top: Make the test exclusive Ian Rogers
2025-12-24 19:38 ` [PATCH v2 1/2] perf tests kvm: Avoid leaving perf.data.guest file around Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.