Re: [PATCH v1 3/3] dt-bindings: google,cros-ec-keyb: add fn-key and f-keymap props

[Rob Herring <robh@kernel.org>]

On Tue, Dec 09, 2025 at 03:47:06PM +0000, Fabio Baltieri wrote:
> Add binding documentation for the fn-key and fn-keymap properties,
> verify that the two new properties are either both preseent or none.
> 
> Signed-off-by: Fabio Baltieri <fabiobaltieri@chromium.org>
> ---
>  .../bindings/input/google,cros-ec-keyb.yaml   | 60 +++++++++++++++----
>  1 file changed, 49 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index fefaaf46a240..56adf9026010 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -44,6 +44,20 @@ properties:
>        where the lower 16 bits are reserved. This property is specified only
>        when the keyboard has a custom design for the top row keys.
>  
> +  fn-key:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |
> +      An u32 containing the coordinate of the Fn key, use the MATRIX_KEY(row,
> +      col, code) macro, code is ignored.
> +
> +  fn-keymap:

If keymap is linux,keymap, then this should perhaps be linux,fn-keymap. 
Depends if we still think linux,keymap is Linux specific?

> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    minItems: 1
> +    maxItems: 32
> +    description: |
> +      An array of u32 mapping the row, column and codes for the function keys,
> +      use the MATRIX_KEY macro to define the elements.
> +
>  dependencies:
>    function-row-physmap: [ 'linux,keymap' ]
>    google,needs-ghost-filter: [ 'linux,keymap' ]
> @@ -51,17 +65,28 @@ dependencies:
>  required:
>    - compatible
>  
> -if:
> -  properties:
> -    compatible:
> -      contains:
> -        const: google,cros-ec-keyb
> -then:
> -  $ref: /schemas/input/matrix-keymap.yaml#
> -  required:
> -    - keypad,num-rows
> -    - keypad,num-columns
> -    - linux,keymap
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: google,cros-ec-keyb
> +    then:
> +      $ref: /schemas/input/matrix-keymap.yaml#
> +      required:
> +        - keypad,num-rows
> +        - keypad,num-columns
> +        - linux,keymap
> +  - if:
> +      anyOf:
> +        - required:
> +          - fn-key
> +        - required:
> +          - fn-keymap
> +    then:
> +      required:
> +        - fn-key
> +        - fn-keymap

This can be more concisely written as:

dependencies:
  fn-key: [fn-keymap]
  fn-keymap: [fn-key]