From: Fabio Baltieri <fabiobaltieri@chromium.org>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Simon Glass <sjg@chromium.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] dt-bindings: google,cros-ec-keyb: add fn-key and f-keymap props
Date: Wed, 10 Dec 2025 18:00:29 +0000 [thread overview]
Message-ID: <aTm1PVLrS7Ra0OTF@google.com> (raw)
In-Reply-To: <20251209192243.GA963693-robh@kernel.org>
Hey Rob, thanks for the review.
On Tue, Dec 09, 2025 at 01:22:43PM -0600, Rob Herring wrote:
> On Tue, Dec 09, 2025 at 03:47:06PM +0000, Fabio Baltieri wrote:
> > + fn-key:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: |
> > + An u32 containing the coordinate of the Fn key, use the MATRIX_KEY(row,
> > + col, code) macro, code is ignored.
> > +
> > + fn-keymap:
>
> If keymap is linux,keymap, then this should perhaps be linux,fn-keymap.
> Depends if we still think linux,keymap is Linux specific?
I'm open for suggestions, trying to understand the pattern, these are
specific to this binding I think if anything they should be
google,fn-key and google,fn-keymap, similarly to the existing
google,needs-ghost-filter -- no idea why function-row-physmap was not
prefixed but I guess it slipped in and now it's not worth changing it.
Would it make sense?
Thanks,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2025-12-10 18:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 15:47 [PATCH v1 0/3] Input: cros_ec_keyb: add function key support Fabio Baltieri
2025-12-09 15:47 ` [PATCH v1 1/3] Input: cros_ec_keyb: clarify key event error message Fabio Baltieri
2025-12-11 13:29 ` Simon Glass
2025-12-13 9:40 ` Dmitry Torokhov
2025-12-09 15:47 ` [PATCH v1 2/3] Input: cros_ec_keyb: add function key support Fabio Baltieri
2025-12-11 13:29 ` Simon Glass
2025-12-15 13:09 ` Fabio Baltieri
2025-12-09 15:47 ` [PATCH v1 3/3] dt-bindings: google,cros-ec-keyb: add fn-key and f-keymap props Fabio Baltieri
2025-12-09 17:24 ` Rob Herring (Arm)
2025-12-09 19:22 ` Rob Herring
2025-12-10 18:00 ` Fabio Baltieri [this message]
2025-12-12 4:44 ` Dmitry Torokhov
2025-12-16 12:23 ` Fabio Baltieri
2025-12-17 18:05 ` Dmitry Torokhov
2025-12-23 15:29 ` Fabio Baltieri
-- strict thread matches above, loose matches on Subject: below --
2025-12-16 2:40 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTm1PVLrS7Ra0OTF@google.com \
--to=fabiobaltieri@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sjg@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.