All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com,
	apopple@nvidia.com, airlied@gmail.com,
	"Simona Vetter" <simona.vetter@ffwll.ch>,
	felix.kuehling@amd.com,
	"Christian König" <christian.koenig@amd.com>,
	dakr@kernel.org, "Mrozek, Michal" <michal.mrozek@intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>
Subject: [PATCH v3 17/22] drm/xe/svm: Document how xe keeps drm_pagemap references
Date: Wed, 10 Dec 2025 12:07:37 +0100	[thread overview]
Message-ID: <20251210110742.107575-18-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20251210110742.107575-1-thomas.hellstrom@linux.intel.com>

As an aid to understanding the lifetime of the drm_pagemaps used
by the xe driver, document how the xe driver keeps the
drm_pagemap references.

v3:
- Fix formatting (Matt Brost)

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_svm.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
index 9eb288b8b57b..8d230eda3360 100644
--- a/drivers/gpu/drm/xe/xe_svm.c
+++ b/drivers/gpu/drm/xe/xe_svm.c
@@ -28,6 +28,27 @@
 #define XE_PEER_PAGEMAP ((void *)0ul)
 #define XE_PEER_VM ((void *)1ul)
 
+/**
+ * DOC: drm_pagemap reference-counting in xe:
+ *
+ * In addition to the drm_pagemap internal reference counting by its zone
+ * device data, the xe driver holds the following long-time references:
+ *
+ * - struct xe_pagemap:
+ *	The xe_pagemap struct derives from struct drm_pagemap and uses its
+ *	reference count.
+ * - SVM-enabled VMs:
+ *	SVM-enabled VMs look up and keeps a reference to all xe_pagemaps on
+ *	the same device.
+ * - VMAs:
+ *	vmas keep a reference on the drm_pagemap indicated by a gpu_madvise()
+ *	call.
+ *
+ * In addition, all drm_pagemap or xe_pagemap pointers where lifetime cannot
+ * be guaranteed by a vma reference under the vm lock should keep a reference.
+ * That includes the range->pages.dpagemap pointer.
+ */
+
 static int xe_svm_get_pagemaps(struct xe_vm *vm);
 
 void *xe_svm_private_page_owner(struct xe_vm *vm, bool force_smem)
-- 
2.51.1


  parent reply	other threads:[~2025-12-10 11:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 11:07 [PATCH v3 00/22] Dynamic drm_pagemaps and Initial multi-device SVM Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 01/22] drm/xe/svm: Fix a debug printout Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 02/22] drm/pagemap, drm/xe: Ensure that the devmem allocation is idle before use Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 03/22] drm/pagemap, drm/xe: Add refcounting to struct drm_pagemap Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 04/22] drm/pagemap: Add a refcounted drm_pagemap backpointer to struct drm_pagemap_zdd Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 05/22] drm/pagemap, drm/xe: Manage drm_pagemap provider lifetimes Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 06/22] drm/pagemap: Add a drm_pagemap cache and shrinker Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 07/22] drm/xe: Use the " Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 08/22] drm/pagemap: Remove the drm_pagemap_create() interface Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 09/22] drm/pagemap_util: Add a utility to assign an owner to a set of interconnected gpus Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 10/22] drm/xe: Use the drm_pagemap_util helper to get a svm pagemap owner Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 11/22] drm/xe: Pass a drm_pagemap pointer around with the memory advise attributes Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 12/22] drm/xe: Use the vma attibute drm_pagemap to select where to migrate Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 13/22] drm/xe: Simplify madvise_preferred_mem_loc() Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 14/22] drm/xe/uapi: Extend the madvise functionality to support foreign pagemap placement for svm Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 15/22] drm/xe: Support pcie p2p dma as a fast interconnect Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 16/22] drm/xe/vm: Add a couple of VM debug printouts Thomas Hellström
2025-12-10 11:07 ` Thomas Hellström [this message]
2025-12-10 11:07 ` [PATCH v3 18/22] drm/pagemap, drm/xe: Clean up the use of the device-private page owner Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 19/22] drm/gpusvm: Introduce a function to scan the current migration state Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 20/22] drm/xe: Use drm_gpusvm_scan_mm() Thomas Hellström
2025-12-10 11:07 ` [PATCH v3 21/22] drm/pagemap, drm/xe: Support destination migration over interconnect Thomas Hellström
2025-12-10 19:58   ` kernel test robot
2025-12-11  3:38   ` kernel test robot
2025-12-10 11:07 ` [PATCH v3 22/22] drm/pagemap: Support source " Thomas Hellström
2025-12-11 10:23 ` ✗ CI.checkpatch: warning for Dynamic drm_pagemaps and Initial multi-device SVM (rev4) Patchwork
2025-12-11 10:23 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251210110742.107575-18-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=apopple@nvidia.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felix.kuehling@amd.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=matthew.brost@intel.com \
    --cc=michal.mrozek@intel.com \
    --cc=simona.vetter@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.