Re: [PATCH 02/12] ext4/006: call e2fsck directly

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Dec 10, 2025 at 06:46:48AM +0100, Christoph Hellwig wrote:
> _check_scratch_fs takes an optional device name, but no optional
> arguments.  Call e2fsck directly for this extN-specific test instead.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/ext4/006 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/ext4/006 b/tests/ext4/006
> index 2ece22a4bd1e..07dcf356b0bc 100755
> --- a/tests/ext4/006
> +++ b/tests/ext4/006
> @@ -44,7 +44,7 @@ repair_scratch() {
>  	res=$?
>  	if [ "${res}" -eq 0 ]; then
>  		echo "++ allegedly fixed, reverify" >> "${FSCK_LOG}"
> -		_check_scratch_fs -n >> "${FSCK_LOG}" 2>&1
> +		e2fsck -n >> "${FSCK_LOG}" 2>&1

Doesn't this need a device name?  e.g. e2fsck -n $SCRATCH_DEV ?

--D

>  		res=$?
>  	fi
>  	echo "++ fsck returns ${res}" >> "${FSCK_LOG}"
> -- 
> 2.47.3
> 
>