From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
Anand Jain <anand.jain@oracle.com>,
Filipe Manana <fdmanana@suse.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 12/12] xfs/650: require a real SCRATCH_RTDEV
Date: Thu, 11 Dec 2025 05:54:00 +0100 [thread overview]
Message-ID: <20251211045400.GB26257@lst.de> (raw)
In-Reply-To: <20251210225043.GI94594@frogsfrogsfrogs>
On Wed, Dec 10, 2025 at 02:50:43PM -0800, Darrick J. Wong wrote:
> Aha, I missed that an earlier patch created it. :(
>
> The one downside to not injecting a rt device here is that now the only
> testing for the actual bug is if you happen to have rt enabled. That
> used to be a concern of mine, but maybe between you, me, Meta, and the
> kdevops folks there's enough now.
I guess that was the reason to create it, but on the other hand injecting
new devices is a mess. One option would be to totally inject the devices,
but that requires a lot of boilerplate as done in the labelling test.
So I think the concept of "you need a RT device to test RT specific
code" should be ok, even if your concern is real.
prev parent reply other threads:[~2025-12-11 4:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 5:46 stop overriding SCRATCH_{,LOG,RT}DEV Christoph Hellwig
2025-12-10 5:46 ` [PATCH 01/12] dmflakey: override SCRATCH_DEV in _init_flakey Christoph Hellwig
2025-12-10 5:46 ` [PATCH 02/12] ext4/006: call e2fsck directly Christoph Hellwig
2025-12-10 19:32 ` Darrick J. Wong
2025-12-11 4:52 ` Christoph Hellwig
2025-12-10 5:46 ` [PATCH 03/12] common: add a _check_dev_fs helper Christoph Hellwig
2025-12-10 23:24 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 04/12] ext4/032: use _check_dev_fs Christoph Hellwig
2025-12-10 23:24 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 05/12] generic/590: split XFS RT specific bits out Christoph Hellwig
2025-12-10 22:51 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 06/12] xfs/157: don't override SCRATCH_{,LOG,RT}DEV Christoph Hellwig
2025-12-10 20:05 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 07/12] xfs/185: don't use SCRATCH_{,RT}DEV helpers Christoph Hellwig
2025-12-10 20:02 ` Darrick J. Wong
2025-12-11 5:00 ` Christoph Hellwig
2025-12-10 5:46 ` [PATCH 08/12] xfs/424: don't use SCRATCH_DEV helpers Christoph Hellwig
2025-12-10 19:55 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 09/12] xfs/521: require a real SCRATCH_RTDEV Christoph Hellwig
2025-12-10 19:54 ` Darrick J. Wong
2025-12-11 4:58 ` Christoph Hellwig
2025-12-10 5:46 ` [PATCH 10/12] xfs/528: " Christoph Hellwig
2025-12-10 19:52 ` Darrick J. Wong
2025-12-11 4:57 ` Christoph Hellwig
2025-12-10 5:46 ` [PATCH 11/12] xfs/530: " Christoph Hellwig
2025-12-10 19:49 ` Darrick J. Wong
2025-12-11 4:55 ` Christoph Hellwig
2025-12-12 20:00 ` Darrick J. Wong
2025-12-10 5:46 ` [PATCH 12/12] xfs/650: " Christoph Hellwig
2025-12-10 19:45 ` Darrick J. Wong
2025-12-10 22:50 ` Darrick J. Wong
2025-12-11 4:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251211045400.GB26257@lst.de \
--to=hch@lst.de \
--cc=anand.jain@oracle.com \
--cc=djwong@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.