From: "Mickaël Salaün" <mic@digikod.net>
To: "Günther Noack" <gnoack@google.com>
Cc: Tingmao Wang <m@maowtm.org>,
Justin Suess <utilityemal77@gmail.com>, Jan Kara <jack@suse.cz>,
Abhinav Saxena <xandfury@gmail.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v6 04/10] landlock: Fix wrong type usage
Date: Fri, 12 Dec 2025 12:13:35 +0100 [thread overview]
Message-ID: <20251212.Ohme7Thee9Bu@digikod.net> (raw)
In-Reply-To: <aTvqrOomA3v52sIg@google.com>
On Fri, Dec 12, 2025 at 11:13:19AM +0100, Günther Noack wrote:
> On Sat, Dec 06, 2025 at 05:11:06PM +0000, Tingmao Wang wrote:
> > I think, based on my best understanding, that this type is likely a typo
> > (even though in the end both are u16)
> >
> > Signed-off-by: Tingmao Wang <m@maowtm.org>
> > Fixes: 2fc80c69df82 ("landlock: Log file-related denials")
> > ---
> >
> > Changes in v2:
> > - Added Fixes tag
> >
> > security/landlock/audit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/landlock/audit.c b/security/landlock/audit.c
> > index 1a9d3f4e3369..d51563712325 100644
> > --- a/security/landlock/audit.c
> > +++ b/security/landlock/audit.c
> > @@ -191,7 +191,7 @@ static size_t get_denied_layer(const struct landlock_ruleset *const domain,
> > long youngest_layer = -1;
> >
> > for_each_set_bit(access_bit, &access_req, layer_masks_size) {
> > - const access_mask_t mask = (*layer_masks)[access_bit];
> > + const layer_mask_t mask = (*layer_masks)[access_bit];
> > long layer;
> >
> > if (!mask)
> > --
> > 2.52.0
>
> Agreed, thanks!
>
> Reviewed-by: Günther Noack <gnoack@google.com>
Thanks, I pushed it to the next branch.
>
> —Günther
>
next prev parent reply other threads:[~2025-12-12 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 17:11 [PATCH v6 00/10] Implement LANDLOCK_ADD_RULE_QUIET Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 01/10] landlock: Add a place for flags to layer rules Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 02/10] landlock: Add API support and docs for the quiet flags Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 03/10] landlock: Suppress logging when quiet flag is present Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 04/10] landlock: Fix wrong type usage Tingmao Wang
2025-12-12 10:13 ` Günther Noack
2025-12-12 11:13 ` Mickaël Salaün [this message]
2025-12-06 17:11 ` [PATCH v6 05/10] samples/landlock: Add quiet flag support to sandboxer Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 06/10] selftests/landlock: Replace hard-coded 16 with a constant Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 07/10] selftests/landlock: add tests for quiet flag with fs rules Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 08/10] selftests/landlock: add tests for quiet flag with net rules Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 09/10] selftests/landlock: Add tests for quiet flag with scope Tingmao Wang
2025-12-06 17:11 ` [PATCH v6 10/10] selftests/landlock: Add tests for invalid use of quiet flag Tingmao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251212.Ohme7Thee9Bu@digikod.net \
--to=mic@digikod.net \
--cc=gnoack@google.com \
--cc=jack@suse.cz \
--cc=linux-security-module@vger.kernel.org \
--cc=m@maowtm.org \
--cc=utilityemal77@gmail.com \
--cc=xandfury@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.