Re: [PATCH v6 04/10] landlock: Fix wrong type usage

["Günther Noack" <gnoack@google.com>]

On Sat, Dec 06, 2025 at 05:11:06PM +0000, Tingmao Wang wrote:
> I think, based on my best understanding, that this type is likely a typo
> (even though in the end both are u16)
> 
> Signed-off-by: Tingmao Wang <m@maowtm.org>
> Fixes: 2fc80c69df82 ("landlock: Log file-related denials")
> ---
> 
> Changes in v2:
> - Added Fixes tag
> 
>  security/landlock/audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/landlock/audit.c b/security/landlock/audit.c
> index 1a9d3f4e3369..d51563712325 100644
> --- a/security/landlock/audit.c
> +++ b/security/landlock/audit.c
> @@ -191,7 +191,7 @@ static size_t get_denied_layer(const struct landlock_ruleset *const domain,
>  	long youngest_layer = -1;
>  
>  	for_each_set_bit(access_bit, &access_req, layer_masks_size) {
> -		const access_mask_t mask = (*layer_masks)[access_bit];
> +		const layer_mask_t mask = (*layer_masks)[access_bit];
>  		long layer;
>  
>  		if (!mask)
> -- 
> 2.52.0

Agreed, thanks!

Reviewed-by: Günther Noack <gnoack@google.com>

—Günther