All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] pinctrl: fix compile test defaults
@ 2025-12-12  2:10 Johan Hovold
  2025-12-25 20:28 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2025-12-12  2:10 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-gpio, linux-kernel, Johan Hovold, Conor Dooley

Enabling compile testing should not enable every individual driver (we
have "allyesconfig" for that) but two new drivers got this wrong.

Default to n instead of ARCH_MICROCHIP as these drivers are not needed
in every Microchip build either.

Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---

Changes in v2
 - default to n instead of ARCH_MICROCHIP as suggested by Conor


 drivers/pinctrl/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bc7f37afc48b..0ea117581bde 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -491,7 +491,6 @@ config PINCTRL_PIC64GX
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
 	help
 	  This selects the pinctrl driver for gpio2 on pic64gx.
 
@@ -511,7 +510,6 @@ config PINCTRL_POLARFIRE_SOC
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
 	help
 	  This selects the pinctrl driver for Microchip Polarfire SoC.
 
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] pinctrl: fix compile test defaults
  2025-12-12  2:10 [PATCH v2] pinctrl: fix compile test defaults Johan Hovold
@ 2025-12-25 20:28 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-12-25 20:28 UTC (permalink / raw)
  To: Johan Hovold; +Cc: linux-gpio, linux-kernel, Conor Dooley

On Fri, Dec 12, 2025 at 3:09 AM Johan Hovold <johan@kernel.org> wrote:

> Enabling compile testing should not enable every individual driver (we
> have "allyesconfig" for that) but two new drivers got this wrong.
>
> Default to n instead of ARCH_MICROCHIP as these drivers are not needed
> in every Microchip build either.
>
> Fixes: 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
> Fixes: 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
> Cc: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Patch applied as nonurgent fix.

Thanks Johan!
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-25 20:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-12  2:10 [PATCH v2] pinctrl: fix compile test defaults Johan Hovold
2025-12-25 20:28 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.