Re: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575

[kernel test robot <lkp@intel.com>]

Hi Oder,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.18 next-20251211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oder-Chiou/ASoC-dt-bindings-realtek-rt5575-add-support-for-ALC5575/20251211-190355
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20251211110130.2925541-3-oder_chiou%40realtek.com
patch subject: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20251212/202512120943.V0TRmEDs-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251212/202512120943.V0TRmEDs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512120943.V0TRmEDs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/rt5575.c:256:48: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     256 |                 dev_err(dev, "Get SPI device failure: %d\n", ret);
         |                                                              ^~~
   include/linux/dev_printk.h:154:65: note: expanded from macro 'dev_err'
     154 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                                     ^~~~~~~~~~~
   sound/soc/codecs/rt5575.c:252:9: note: initialize the variable 'ret' to silence this warning
     252 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +256 sound/soc/codecs/rt5575.c

   246	
   247	static int rt5575_fw_load_by_spi(struct rt5575_priv *rt5575)
   248	{
   249		struct i2c_client *i2c = rt5575->i2c;
   250		struct spi_device *spi;
   251		struct device *dev = &i2c->dev;
   252		int ret;
   253	
   254		spi = rt5575_spi_find_device();
   255		if (!spi) {
 > 256			dev_err(dev, "Get SPI device failure: %d\n", ret);
   257			return -ENODEV;
   258		}
   259	
   260		regmap_write(rt5575->dsp_regmap, 0xfafafafa, 0x00000004);
   261		regmap_write(rt5575->dsp_regmap, 0x18008064, 0x00000000);
   262		regmap_write(rt5575->dsp_regmap, 0x18008068, 0x0002ffff);
   263	
   264		ret = rt5575_spi_fw_load(spi);
   265		if (ret) {
   266			dev_err(dev, "Load firmware failure: %d\n", ret);
   267			return -ENODEV;
   268		}
   269	
   270		regmap_write(rt5575->dsp_regmap, 0x18000000, 0x00000000);
   271		regmap_update_bits(rt5575->regmap, RT5575_SW_INT, 1, 1);
   272	
   273		regmap_read_poll_timeout(rt5575->regmap, RT5575_SW_INT, ret, !ret, 100000, 10000000);
   274		if (ret) {
   275			dev_err(dev, "Run firmware failure: %d\n", ret);
   276			return -ENODEV;
   277		}
   278	
   279		return 0;
   280	}
   281	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki