All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575
Date: Sun, 14 Dec 2025 10:11:41 +0800	[thread overview]
Message-ID: <202512140909.a0ok9gVy-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251211110130.2925541-3-oder_chiou@realtek.com>
References: <20251211110130.2925541-3-oder_chiou@realtek.com>
TO: Oder Chiou <oder_chiou@realtek.com>

Hi Oder,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on linus/master v6.18 next-20251212]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oder-Chiou/ASoC-dt-bindings-realtek-rt5575-add-support-for-ALC5575/20251211-190355
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20251211110130.2925541-3-oder_chiou%40realtek.com
patch subject: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575
:::::: branch date: 3 days ago
:::::: commit date: 3 days ago
config: parisc-randconfig-r072-20251214 (https://download.01.org/0day-ci/archive/20251214/202512140909.a0ok9gVy-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512140909.a0ok9gVy-lkp@intel.com/

smatch warnings:
sound/soc/codecs/rt5575.c:256 rt5575_fw_load_by_spi() error: uninitialized symbol 'ret'.

vim +/ret +256 sound/soc/codecs/rt5575.c

56f073d89eb8e0 Oder Chiou 2025-12-11  246  
56f073d89eb8e0 Oder Chiou 2025-12-11  247  static int rt5575_fw_load_by_spi(struct rt5575_priv *rt5575)
56f073d89eb8e0 Oder Chiou 2025-12-11  248  {
56f073d89eb8e0 Oder Chiou 2025-12-11  249  	struct i2c_client *i2c = rt5575->i2c;
56f073d89eb8e0 Oder Chiou 2025-12-11  250  	struct spi_device *spi;
56f073d89eb8e0 Oder Chiou 2025-12-11  251  	struct device *dev = &i2c->dev;
56f073d89eb8e0 Oder Chiou 2025-12-11  252  	int ret;
56f073d89eb8e0 Oder Chiou 2025-12-11  253  
56f073d89eb8e0 Oder Chiou 2025-12-11  254  	spi = rt5575_spi_find_device();
56f073d89eb8e0 Oder Chiou 2025-12-11  255  	if (!spi) {
56f073d89eb8e0 Oder Chiou 2025-12-11 @256  		dev_err(dev, "Get SPI device failure: %d\n", ret);
56f073d89eb8e0 Oder Chiou 2025-12-11  257  		return -ENODEV;
56f073d89eb8e0 Oder Chiou 2025-12-11  258  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  259  
56f073d89eb8e0 Oder Chiou 2025-12-11  260  	regmap_write(rt5575->dsp_regmap, 0xfafafafa, 0x00000004);
56f073d89eb8e0 Oder Chiou 2025-12-11  261  	regmap_write(rt5575->dsp_regmap, 0x18008064, 0x00000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  262  	regmap_write(rt5575->dsp_regmap, 0x18008068, 0x0002ffff);
56f073d89eb8e0 Oder Chiou 2025-12-11  263  
56f073d89eb8e0 Oder Chiou 2025-12-11  264  	ret = rt5575_spi_fw_load(spi);
56f073d89eb8e0 Oder Chiou 2025-12-11  265  	if (ret) {
56f073d89eb8e0 Oder Chiou 2025-12-11  266  		dev_err(dev, "Load firmware failure: %d\n", ret);
56f073d89eb8e0 Oder Chiou 2025-12-11  267  		return -ENODEV;
56f073d89eb8e0 Oder Chiou 2025-12-11  268  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  269  
56f073d89eb8e0 Oder Chiou 2025-12-11  270  	regmap_write(rt5575->dsp_regmap, 0x18000000, 0x00000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  271  	regmap_update_bits(rt5575->regmap, RT5575_SW_INT, 1, 1);
56f073d89eb8e0 Oder Chiou 2025-12-11  272  
56f073d89eb8e0 Oder Chiou 2025-12-11  273  	regmap_read_poll_timeout(rt5575->regmap, RT5575_SW_INT, ret, !ret, 100000, 10000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  274  	if (ret) {
56f073d89eb8e0 Oder Chiou 2025-12-11  275  		dev_err(dev, "Run firmware failure: %d\n", ret);
56f073d89eb8e0 Oder Chiou 2025-12-11  276  		return -ENODEV;
56f073d89eb8e0 Oder Chiou 2025-12-11  277  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  278  
56f073d89eb8e0 Oder Chiou 2025-12-11  279  	return 0;
56f073d89eb8e0 Oder Chiou 2025-12-11  280  }
56f073d89eb8e0 Oder Chiou 2025-12-11  281  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Oder Chiou <oder_chiou@realtek.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575
Date: Wed, 17 Dec 2025 19:06:23 +0300	[thread overview]
Message-ID: <202512140909.a0ok9gVy-lkp@intel.com> (raw)
Message-ID: <20251217160623.kmgYL7ggKWl-XR0CrdQobV1vNuGhP7xdltjL64GlWD0@z> (raw)
In-Reply-To: <20251211110130.2925541-3-oder_chiou@realtek.com>

Hi Oder,

kernel test robot noticed the following build warnings:

https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Oder-Chiou/ASoC-dt-bindings-realtek-rt5575-add-support-for-ALC5575/20251211-190355
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20251211110130.2925541-3-oder_chiou%40realtek.com
patch subject: [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575
config: parisc-randconfig-r072-20251214 (https://download.01.org/0day-ci/archive/20251214/202512140909.a0ok9gVy-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 14.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202512140909.a0ok9gVy-lkp@intel.com/

smatch warnings:
sound/soc/codecs/rt5575.c:256 rt5575_fw_load_by_spi() error: uninitialized symbol 'ret'.

vim +/ret +256 sound/soc/codecs/rt5575.c

56f073d89eb8e0 Oder Chiou 2025-12-11  247  static int rt5575_fw_load_by_spi(struct rt5575_priv *rt5575)
56f073d89eb8e0 Oder Chiou 2025-12-11  248  {
56f073d89eb8e0 Oder Chiou 2025-12-11  249  	struct i2c_client *i2c = rt5575->i2c;
56f073d89eb8e0 Oder Chiou 2025-12-11  250  	struct spi_device *spi;
56f073d89eb8e0 Oder Chiou 2025-12-11  251  	struct device *dev = &i2c->dev;
56f073d89eb8e0 Oder Chiou 2025-12-11  252  	int ret;
56f073d89eb8e0 Oder Chiou 2025-12-11  253  
56f073d89eb8e0 Oder Chiou 2025-12-11  254  	spi = rt5575_spi_find_device();
56f073d89eb8e0 Oder Chiou 2025-12-11  255  	if (!spi) {
56f073d89eb8e0 Oder Chiou 2025-12-11 @256  		dev_err(dev, "Get SPI device failure: %d\n", ret);
                                                                                                     ^^^
ret isn't initialized.

56f073d89eb8e0 Oder Chiou 2025-12-11  257  		return -ENODEV;
56f073d89eb8e0 Oder Chiou 2025-12-11  258  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  259  
56f073d89eb8e0 Oder Chiou 2025-12-11  260  	regmap_write(rt5575->dsp_regmap, 0xfafafafa, 0x00000004);
56f073d89eb8e0 Oder Chiou 2025-12-11  261  	regmap_write(rt5575->dsp_regmap, 0x18008064, 0x00000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  262  	regmap_write(rt5575->dsp_regmap, 0x18008068, 0x0002ffff);
56f073d89eb8e0 Oder Chiou 2025-12-11  263  
56f073d89eb8e0 Oder Chiou 2025-12-11  264  	ret = rt5575_spi_fw_load(spi);
56f073d89eb8e0 Oder Chiou 2025-12-11  265  	if (ret) {
56f073d89eb8e0 Oder Chiou 2025-12-11  266  		dev_err(dev, "Load firmware failure: %d\n", ret);
56f073d89eb8e0 Oder Chiou 2025-12-11  267  		return -ENODEV;

s/-ENODEV/ret/

56f073d89eb8e0 Oder Chiou 2025-12-11  268  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  269  
56f073d89eb8e0 Oder Chiou 2025-12-11  270  	regmap_write(rt5575->dsp_regmap, 0x18000000, 0x00000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  271  	regmap_update_bits(rt5575->regmap, RT5575_SW_INT, 1, 1);
56f073d89eb8e0 Oder Chiou 2025-12-11  272  
56f073d89eb8e0 Oder Chiou 2025-12-11  273  	regmap_read_poll_timeout(rt5575->regmap, RT5575_SW_INT, ret, !ret, 100000, 10000000);
56f073d89eb8e0 Oder Chiou 2025-12-11  274  	if (ret) {
56f073d89eb8e0 Oder Chiou 2025-12-11  275  		dev_err(dev, "Run firmware failure: %d\n", ret);
56f073d89eb8e0 Oder Chiou 2025-12-11  276  		return -ENODEV;
56f073d89eb8e0 Oder Chiou 2025-12-11  277  	}
56f073d89eb8e0 Oder Chiou 2025-12-11  278  
56f073d89eb8e0 Oder Chiou 2025-12-11  279  	return 0;
56f073d89eb8e0 Oder Chiou 2025-12-11  280  }

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


             reply	other threads:[~2025-12-14  2:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-14  2:11 kernel test robot [this message]
2025-12-17 16:06 ` [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575 Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2025-12-11 11:01 [PATCH v9 0/2] " Oder Chiou
2025-12-11 11:01 ` [PATCH v9 1/2] ASoC: dt-bindings: realtek,rt5575: add support for ALC5575 Oder Chiou
2025-12-11 15:38   ` Rob Herring
2025-12-12  8:59     ` Oder Chiou
2025-12-12 13:09       ` Rob Herring
2025-12-11 11:01 ` [PATCH v9 2/2] ASoC: rt5575: Add the codec driver for the ALC5575 Oder Chiou
2025-12-12  1:31   ` kernel test robot
2025-12-14 23:00   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202512140909.a0ok9gVy-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.