All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package: new: add k3conf tool package
@ 2025-12-15 13:24 Sadik SM via buildroot
  2025-12-15 14:00 ` Bryan Brattlof via buildroot
  2025-12-15 14:11 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Sadik SM via buildroot @ 2025-12-15 13:24 UTC (permalink / raw)
  To: buildroot; +Cc: Bryan Brattlof, thomas.petazzoni

From: sadik <s-sadik@ti.com>

add the k3conf tool in the package section

K3CONF is a Linux user-space standalone application
designed to provide a quick'n easy way to dynamically
diagnose Texas Instruments' K3 architecture based
processors. K3CONF is intended to provide similar
experience to that of OMAPCONF that runs on legacy TI platforms.

K3CONF currently supports Texas Instruments AM654, J721E, J7200, 
AM64x,AM62x,J721S2,J784S4,J722S, AM62Ax, AM62Px, and AM62Lx devices.
Along with the BeagleBoard variants of the above mentioned TI SOC's.

Signed-off-by: sadik <s-sadik@ti.com>
---
 DEVELOPERS                 |  3 +++
 package/Config.in          |  1 +
 package/k3conf/Config.in   |  4 ++++
 package/k3conf/k3conf.hash |  2 ++
 package/k3conf/k3conf.mk   | 16 ++++++++++++++++
 5 files changed, 26 insertions(+)
 create mode 100644 package/k3conf/Config.in
 create mode 100644 package/k3conf/k3conf.hash
 create mode 100644 package/k3conf/k3conf.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 1b27df9beb..396452f261 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2962,6 +2962,9 @@ F:	package/agent-proxy/
 N:	Ryan Wilkins <ryan@deadfrog.net>
 F:	package/biosdevname/
 
+N:  Sadik SM <s-sadik@ti.com>
+F:  package/k3conf
+
 N:	Saeed Kazemi <kazemi.ms@gmail.com>
 F:	package/eza/
 F:	package/fd/
diff --git a/package/Config.in b/package/Config.in
index 22970b4d45..a0aa112070 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -110,6 +110,7 @@ menu "Debugging, profiling and benchmark"
 	source "package/google-breakpad/Config.in"
 	source "package/hyperfine/Config.in"
 	source "package/iozone/Config.in"
+	source "package/k3conf/Config.in"
 	source "package/kexec/Config.in"
 	source "package/kexec-lite/Config.in"
 	source "package/kmemd/Config.in"
diff --git a/package/k3conf/Config.in b/package/k3conf/Config.in
new file mode 100644
index 0000000000..f282ad672b
--- /dev/null
+++ b/package/k3conf/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_K3CONF
+    bool "k3conf"
+    help
+      A Powerful Diagnostic Tool for Texas Instruments K3 based Processors.
diff --git a/package/k3conf/k3conf.hash b/package/k3conf/k3conf.hash
new file mode 100644
index 0000000000..47d9eca6a0
--- /dev/null
+++ b/package/k3conf/k3conf.hash
@@ -0,0 +1,2 @@
+# Locally calculated sha256sum
+sha256  a3459f80e7af5672da6b41bc0814114690dd549aac4cf81ba4e5dc84d42ab9c6  k3conf-v0.4-git4.tar.gz
diff --git a/package/k3conf/k3conf.mk b/package/k3conf/k3conf.mk
new file mode 100644
index 0000000000..b248fb63d5
--- /dev/null
+++ b/package/k3conf/k3conf.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# k3conf
+#
+################################################################################
+
+K3CONF_VERSION = v0.4
+K3CONF_SITE = https://git.ti.com/git/k3conf/k3conf.git
+K3CONF_SITE_METHOD = git
+K3CONF_LICENSE = BSD-3-Clause
+K3CONF_LICENSE_FILES = LICENSE
+
+
+K3CONF_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release
+
+$(eval $(cmake-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package: new: add k3conf tool package
  2025-12-15 13:24 [Buildroot] [PATCH] package: new: add k3conf tool package Sadik SM via buildroot
@ 2025-12-15 14:00 ` Bryan Brattlof via buildroot
  2025-12-15 14:22   ` Thomas Petazzoni via buildroot
  2025-12-15 14:11 ` Thomas Petazzoni via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Bryan Brattlof via buildroot @ 2025-12-15 14:00 UTC (permalink / raw)
  To: Sadik SM; +Cc: buildroot, thomas.petazzoni

On December 15, 2025 thus sayeth Sadik SM via buildroot:
> From: sadik <s-sadik@ti.com>
> 
> add the k3conf tool in the package section
> 
> K3CONF is a Linux user-space standalone application
> designed to provide a quick'n easy way to dynamically
> diagnose Texas Instruments' K3 architecture based
> processors. K3CONF is intended to provide similar
> experience to that of OMAPCONF that runs on legacy TI platforms.
> 
> K3CONF currently supports Texas Instruments AM654, J721E, J7200, 
> AM64x,AM62x,J721S2,J784S4,J722S, AM62Ax, AM62Px, and AM62Lx devices.
> Along with the BeagleBoard variants of the above mentioned TI SOC's.
>

Works for me! I wonder if we should call out the kernel needs to provide 
/dev/mem for this tool[0] 

[0] https://git.ti.com/cgit/k3conf/k3conf/tree/common/mmio.c#n39

> Signed-off-by: sadik <s-sadik@ti.com>
> ---
>  DEVELOPERS                 |  3 +++
>  package/Config.in          |  1 +
>  package/k3conf/Config.in   |  4 ++++
>  package/k3conf/k3conf.hash |  2 ++
>  package/k3conf/k3conf.mk   | 16 ++++++++++++++++
>  5 files changed, 26 insertions(+)
>  create mode 100644 package/k3conf/Config.in
>  create mode 100644 package/k3conf/k3conf.hash
>  create mode 100644 package/k3conf/k3conf.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 1b27df9beb..396452f261 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2962,6 +2962,9 @@ F:	package/agent-proxy/
>  N:	Ryan Wilkins <ryan@deadfrog.net>
>  F:	package/biosdevname/
>  
> +N:  Sadik SM <s-sadik@ti.com>
> +F:  package/k3conf

I think we may have some white-space issues here

~Bryan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package: new: add k3conf tool package
  2025-12-15 13:24 [Buildroot] [PATCH] package: new: add k3conf tool package Sadik SM via buildroot
  2025-12-15 14:00 ` Bryan Brattlof via buildroot
@ 2025-12-15 14:11 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-15 14:11 UTC (permalink / raw)
  To: Sadik SM; +Cc: buildroot, Bryan Brattlof

Hello,

Thanks a lot for your patch! Please find below a review of your patch.

First the commit title should be:

	package/k3conf: new package

On Mon, 15 Dec 2025 18:54:25 +0530
Sadik SM <s-sadik@ti.com> wrote:

> From: sadik <s-sadik@ti.com>

Please use your full first name / last name, with proper capitalization.

> add the k3conf tool in the package section

This sentence is not needed.

> 
> K3CONF is a Linux user-space standalone application
> designed to provide a quick'n easy way to dynamically
> diagnose Texas Instruments' K3 architecture based
> processors. K3CONF is intended to provide similar
> experience to that of OMAPCONF that runs on legacy TI platforms.
> 
> K3CONF currently supports Texas Instruments AM654, J721E, J7200, 
> AM64x,AM62x,J721S2,J784S4,J722S, AM62Ax, AM62Px, and AM62Lx devices.
> Along with the BeagleBoard variants of the above mentioned TI SOC's.
> 
> Signed-off-by: sadik <s-sadik@ti.com>

Please use your full first name / last name, with proper capitalization.

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 1b27df9beb..396452f261 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2962,6 +2962,9 @@ F:	package/agent-proxy/
>  N:	Ryan Wilkins <ryan@deadfrog.net>
>  F:	package/biosdevname/
>  
> +N:  Sadik SM <s-sadik@ti.com>
> +F:  package/k3conf

Please use the same indentation as in the rest of the document. Put a
final / in package/k3conf/, like for other entries.

Use your full first name / last name.


> diff --git a/package/k3conf/Config.in b/package/k3conf/Config.in
> new file mode 100644
> index 0000000000..f282ad672b
> --- /dev/null
> +++ b/package/k3conf/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_K3CONF
> +    bool "k3conf"
> +    help
> +      A Powerful Diagnostic Tool for Texas Instruments K3 based Processors.

Please find the indentation to match other Config.in files: one tab for
bool/help, one tab + two spaces for the help text.

Add the upstream URL of the project at the end of the help text.

You can run "make check-package" to check for coding style issues.

I think you can add a "depends on BR2_aarch64" dependency to this
package since anyway it doesn't make sense for other CPU architectures.


> diff --git a/package/k3conf/k3conf.hash b/package/k3conf/k3conf.hash
> new file mode 100644
> index 0000000000..47d9eca6a0
> --- /dev/null
> +++ b/package/k3conf/k3conf.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated sha256sum
> +sha256  a3459f80e7af5672da6b41bc0814114690dd549aac4cf81ba4e5dc84d42ab9c6  k3conf-v0.4-git4.tar.gz

Please add a hash for the license file.

> diff --git a/package/k3conf/k3conf.mk b/package/k3conf/k3conf.mk
> new file mode 100644
> index 0000000000..b248fb63d5
> --- /dev/null
> +++ b/package/k3conf/k3conf.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# k3conf
> +#
> +################################################################################
> +
> +K3CONF_VERSION = v0.4
> +K3CONF_SITE = https://git.ti.com/git/k3conf/k3conf.git
> +K3CONF_SITE_METHOD = git
> +K3CONF_LICENSE = BSD-3-Clause
> +K3CONF_LICENSE_FILES = LICENSE
> +
> +

Only one blank line.

> +K3CONF_CONF_OPTS = -DCMAKE_BUILD_TYPE=Release

This is not needed, it's already passed by the cmake-package
infrastructure.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package: new: add k3conf tool package
  2025-12-15 14:00 ` Bryan Brattlof via buildroot
@ 2025-12-15 14:22   ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-12-15 14:22 UTC (permalink / raw)
  To: Bryan Brattlof; +Cc: Sadik SM, buildroot

On Mon, 15 Dec 2025 08:00:51 -0600
Bryan Brattlof <bb@ti.com> wrote:

> Works for me! I wonder if we should call out the kernel needs to provide 
> /dev/mem for this tool[0] 
> 
> [0] https://git.ti.com/cgit/k3conf/k3conf/tree/common/mmio.c#n39

You can always do:

define K3CONF_LINUX_CONFIG_FIXUPS
        $(call KCONFIG_ENABLE_OPT,CONFIG_DEVMEM)
endef

if you want to be sure it is enabled.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-15 14:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-15 13:24 [Buildroot] [PATCH] package: new: add k3conf tool package Sadik SM via buildroot
2025-12-15 14:00 ` Bryan Brattlof via buildroot
2025-12-15 14:22   ` Thomas Petazzoni via buildroot
2025-12-15 14:11 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.