[LTP] [PATCH] ci: fix patch download when using curl

[LTP] [PATCH] ci: fix patch download when using curl

[Andrea Cervesato]

From: Andrea Cervesato <andrea.cervesato@suse.com>

curl started to fail on CI after bots have been introduced to verify
that a human is interacting with patchwork. This creates an issue when
we need to download patches, since at the very first redirection we will
miss the server hosting our patches. By using `--location-trusted`, we
trust the bots redirection and we make sure that it's possible to
download the patch which is going to be applied via `git am`.

Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
---
 .github/workflows/ci-docker-build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci-docker-build.yml b/.github/workflows/ci-docker-build.yml
index 09eb8bb6d446b3e7100f43844942a5dd3976badb..408eb9a69f5cbebf725751633db46169be288bb8 100644
--- a/.github/workflows/ci-docker-build.yml
+++ b/.github/workflows/ci-docker-build.yml
@@ -155,7 +155,7 @@ jobs:
         git config --global --add safe.directory "$GITHUB_WORKSPACE"
 
         git checkout -b review_patch_series_"${{ inputs.SERIES_ID }}"
-        curl -k "${{ inputs.SERIES_MBOX }}" | git am
+        curl -k -L --max-redirs 1 --location-trusted "${{ inputs.SERIES_MBOX }}" | git am
 
         ./ci/tools/patchwork.sh state "${{ inputs.SERIES_ID }}" "needs-review-ack"
 

---
base-commit: d0e0426529619868195ff1dc8decd88c8259090c
change-id: 20251215-fix_ci-6d1edd26198d

Best regards,
-- 
Andrea Cervesato <andrea.cervesato@suse.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] ci: fix patch download when using curl

[Petr Vorel]

Hi Andrea,

> curl started to fail on CI after bots have been introduced to verify
> that a human is interacting with patchwork. This creates an issue when
> we need to download patches, since at the very first redirection we will
> miss the server hosting our patches. By using `--location-trusted`, we
> trust the bots redirection and we make sure that it's possible to
> download the patch which is going to be applied via `git am`.

> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  .github/workflows/ci-docker-build.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/.github/workflows/ci-docker-build.yml b/.github/workflows/ci-docker-build.yml
> index 09eb8bb6d446b3e7100f43844942a5dd3976badb..408eb9a69f5cbebf725751633db46169be288bb8 100644
> --- a/.github/workflows/ci-docker-build.yml
> +++ b/.github/workflows/ci-docker-build.yml
> @@ -155,7 +155,7 @@ jobs:
>          git config --global --add safe.directory "$GITHUB_WORKSPACE"

>          git checkout -b review_patch_series_"${{ inputs.SERIES_ID }}"
> -        curl -k "${{ inputs.SERIES_MBOX }}" | git am
> +        curl -k -L --max-redirs 1 --location-trusted "${{ inputs.SERIES_MBOX }}" | git am

Hopefully --max-redirs 1 is enough.
Thanks for looking into this!

Acked-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] ci: fix patch download when using curl

[Ben Copeland]

On Mon, 15 Dec 2025 at 15:55, Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Andrea,
>
> > curl started to fail on CI after bots have been introduced to verify
> > that a human is interacting with patchwork. This creates an issue when
> > we need to download patches, since at the very first redirection we will
> > miss the server hosting our patches. By using `--location-trusted`, we
> > trust the bots redirection and we make sure that it's possible to
> > download the patch which is going to be applied via `git am`.
>
> > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > ---
> >  .github/workflows/ci-docker-build.yml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/.github/workflows/ci-docker-build.yml b/.github/workflows/ci-docker-build.yml
> > index 09eb8bb6d446b3e7100f43844942a5dd3976badb..408eb9a69f5cbebf725751633db46169be288bb8 100644
> > --- a/.github/workflows/ci-docker-build.yml
> > +++ b/.github/workflows/ci-docker-build.yml
> > @@ -155,7 +155,7 @@ jobs:
> >          git config --global --add safe.directory "$GITHUB_WORKSPACE"
>
> >          git checkout -b review_patch_series_"${{ inputs.SERIES_ID }}"
> > -        curl -k "${{ inputs.SERIES_MBOX }}" | git am
> > +        curl -k -L --max-redirs 1 --location-trusted "${{ inputs.SERIES_MBOX }}" | git am
>
> Hopefully --max-redirs 1 is enough.
> Thanks for looking into this!

I suggest adding --retry to the CURL call. --retry 3. At least then
when curl fails, it won't fail on the first?

Ben

>
> Acked-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] ci: fix patch download when using curl

[Andrea Cervesato via ltp]

>
> I suggest adding --retry to the CURL call. --retry 3. At least then
> when curl fails, it won't fail on the first?
>
> Ben
>

+1

I will send a v2


-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] ci: fix patch download when using curl

[Petr Vorel]

...
> > > -        curl -k "${{ inputs.SERIES_MBOX }}" | git am
> > > +        curl -k -L --max-redirs 1 --location-trusted "${{ inputs.SERIES_MBOX }}" | git am

> > Hopefully --max-redirs 1 is enough.
> > Thanks for looking into this!

> I suggest adding --retry to the CURL call. --retry 3. At least then
> when curl fails, it won't fail on the first?

+1, sounds reasonable.

Kind regards,
Petr

> Ben

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp