Re: [PATCH v2 3/3] randomize_kstack: Unify random source across arches

From: kernel test robot <lkp@intel.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Huacai Chen <chenhuacai@kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Kees Cook <kees@kernel.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Mark Rutland <mark.rutland@arm.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	Ryan Roberts <ryan.roberts@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
	linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2 3/3] randomize_kstack: Unify random source across arches
Date: Tue, 16 Dec 2025 23:27:25 +0800	[thread overview]
Message-ID: <202512162320.WFgo042e-lkp@intel.com> (raw)
In-Reply-To: <20251215163520.1144179-4-ryan.roberts@arm.com>

Hi Ryan,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on akpm-mm/mm-everything linus/master v6.19-rc1 next-20251216]
[cannot apply to kees/for-next/hardening kees/for-next/execve]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ryan-Roberts/prandom-Convert-prandom_u32_state-to-__always_inline/20251216-013546
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20251215163520.1144179-4-ryan.roberts%40arm.com
patch subject: [PATCH v2 3/3] randomize_kstack: Unify random source across arches
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20251216/202512162320.WFgo042e-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251216/202512162320.WFgo042e-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512162320.WFgo042e-lkp@intel.com/

All errors (new ones prefixed by >>):

>> arch/x86/kvm/svm/svm.c:5509:1: error: redefinition of '__inittest'
    5509 | module_init(svm_init)
         | ^
   include/linux/module.h:132:42: note: expanded from macro 'module_init'
     132 |         static inline initcall_t __maybe_unused __inittest(void)                \
         |                                                 ^
   include/linux/randomize_kstack.h:86:1: note: previous definition is here
      86 | late_initcall(random_kstack_init);
         | ^
   include/linux/module.h:125:28: note: expanded from macro 'late_initcall'
     125 | #define late_initcall(fn)               module_init(fn)
         |                                         ^
   include/linux/module.h:132:42: note: expanded from macro 'module_init'
     132 |         static inline initcall_t __maybe_unused __inittest(void)                \
         |                                                 ^
>> arch/x86/kvm/svm/svm.c:5509:1: error: redefinition of 'init_module'
    5509 | module_init(svm_init)
         | ^
   include/linux/module.h:134:6: note: expanded from macro 'module_init'
     134 |         int init_module(void) __copy(initfn)                    \
         |             ^
   include/linux/randomize_kstack.h:86:1: note: previous definition is here
      86 | late_initcall(random_kstack_init);
         | ^
   include/linux/module.h:125:28: note: expanded from macro 'late_initcall'
     125 | #define late_initcall(fn)               module_init(fn)
         |                                         ^
   include/linux/module.h:134:6: note: expanded from macro 'module_init'
     134 |         int init_module(void) __copy(initfn)                    \
         |             ^
   2 errors generated.
--
>> drivers/misc/sgi-xp/xpc_main.c:1285:1: error: redefinition of '__inittest'
    1285 | module_init(xpc_init);
         | ^
   include/linux/module.h:132:42: note: expanded from macro 'module_init'
     132 |         static inline initcall_t __maybe_unused __inittest(void)                \
         |                                                 ^
   include/linux/randomize_kstack.h:86:1: note: previous definition is here
      86 | late_initcall(random_kstack_init);
         | ^
   include/linux/module.h:125:28: note: expanded from macro 'late_initcall'
     125 | #define late_initcall(fn)               module_init(fn)
         |                                         ^
   include/linux/module.h:132:42: note: expanded from macro 'module_init'
     132 |         static inline initcall_t __maybe_unused __inittest(void)                \
         |                                                 ^
>> drivers/misc/sgi-xp/xpc_main.c:1285:1: error: redefinition of 'init_module'
    1285 | module_init(xpc_init);
         | ^
   include/linux/module.h:134:6: note: expanded from macro 'module_init'
     134 |         int init_module(void) __copy(initfn)                    \
         |             ^
   include/linux/randomize_kstack.h:86:1: note: previous definition is here
      86 | late_initcall(random_kstack_init);
         | ^
   include/linux/module.h:125:28: note: expanded from macro 'late_initcall'
     125 | #define late_initcall(fn)               module_init(fn)
         |                                         ^
   include/linux/module.h:134:6: note: expanded from macro 'module_init'
     134 |         int init_module(void) __copy(initfn)                    \
         |             ^
   2 errors generated.

vim +/__inittest +5509 arch/x86/kvm/svm/svm.c

6aa8b732ca01c3d drivers/kvm/svm.c Avi Kivity 2006-12-10  5508  
6aa8b732ca01c3d drivers/kvm/svm.c Avi Kivity 2006-12-10 @5509  module_init(svm_init)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki